"Please select an spreadsheet file" - not grammatically correct "Please select an ods or xml file" - misses out CSV files, also they should either say 'ODS' or '.ods'.
Created attachment 47295 [details] [review] Bug 15665: Better wording of error messages when importing MARC frameworks To test: 1) Go to Admin -> MARC frameworks 2) Click Import next to any framework. You won't actually be overwriting or importing anything as this is only a string fix, so it can be an existing framework 3) Click the Import button without attaching any file. Confirm it says "Please select a spreadsheet (.csv, .ods, .xml) file." and that this makes sense to you 4) Attempt to attach a file that is not a .csv, .ods or .xml file. You should instantly get an error message saying "Please select a CSV (.csv), ODS (.ods) or XML (.xml) file." Confirm this shows up and makes sense to you
Created attachment 47296 [details] [review] Bug 15665: Better wording of error messages when importing MARC frameworks To test: 1) Go to Admin -> MARC frameworks 2) Click Import next to any framework. You won't actually be overwriting or importing anything as this is only a string fix, so it can be an existing framework 3) Click the Import button without attaching any file. Confirm it says "Please select a spreadsheet (.csv, .ods, .xml) file." and that this makes sense to you 4) Attempt to attach a file that is not a .csv, .ods or .xml file. You should instantly get an error message saying "Please select a CSV (.csv), ODS (.ods) or XML (.xml) file." Confirm this shows up and makes sense to you
Created attachment 47308 [details] [review] [SIGNED-OFF]Bug 15665: Better wording of error messages when importing MARC frameworks To test: 1) Go to Admin -> MARC frameworks 2) Click Import next to any framework. You won't actually be overwriting or importing anything as this is only a string fix, so it can be an existing framework 3) Click the Import button without attaching any file. Confirm it says "Please select a spreadsheet (.csv, .ods, .xml) file." and that this makes sense to you 4) Attempt to attach a file that is not a .csv, .ods or .xml file. You should instantly get an error message saying "Please select a CSV (.csv), ODS (.ods) or XML (.xml) file." Confirm this shows up and makes sense to you Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rewording Ok. Works as described
Aleisha, should not we use the same wording for the 2 alerts?
Created attachment 47363 [details] [review] Bug 15665: Better wording of error messages when importing MARC frameworks UPDATE: Making error messages the same To test: 1) Go to Admin -> MARC frameworks 2) Click Import next to any framework. You won't actually be overwriting or importing anything as this is only a string fix, so it can be an existing framework 3) Click the Import button without attaching any file. Confirm it says "Please select a spreadsheet (.csv, .ods, .xml) file." and that this makes sense to you 4) Attempt to attach a file that is not a .csv, .ods or .xml file. You should instantly get an error message saying "Please select a CSV (.csv), ODS (.ods) or XML (.xml) file." Confirm this shows up and makes sense to you Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rewording Ok. Works as described
Created attachment 47386 [details] [review] Bug 15665: Better wording of error messages when importing MARC frameworks UPDATE: Making error messages the same To test: 1) Go to Admin -> MARC frameworks 2) Click Import next to any framework. You won't actually be overwriting or importing anything as this is only a string fix, so it can be an existing framework 3) Click the Import button without attaching any file. Confirm it says "Please select a spreadsheet (.csv, .ods, .xml) file." and that this makes sense to you 4) Attempt to attach a file that is not a .csv, .ods or .xml file. You should instantly get an error message saying "Please select a CSV (.csv), ODS (.ods) or XML (.xml) file." Confirm this shows up and makes sense to you Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rewording Ok. Works as described Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Created attachment 47458 [details] [review] Bug 15665: Better wording of error messages when importing MARC frameworks UPDATE: Making error messages the same To test: 1) Go to Admin -> MARC frameworks 2) Click Import next to any framework. You won't actually be overwriting or importing anything as this is only a string fix, so it can be an existing framework 3) Click the Import button without attaching any file. Confirm it says "Please select a spreadsheet (.csv, .ods, .xml) file." and that this makes sense to you 4) Attempt to attach a file that is not a .csv, .ods or .xml file. You should instantly get an error message saying "Please select a CSV (.csv), ODS (.ods) or XML (.xml) file." Confirm this shows up and makes sense to you Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rewording Ok. Works as described Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 release. Thanks!