Bug 14464 adds a new button when checking in an item waiting on the holds shelf. The button is labelled "Cancel" and will cancel the hold when clicked. As cancel usually equates to "do nothing" this is a bit confusing, especially in translation (abbrechen vs. stornieren). I'd suggest to rename it to be more explicit: "Cancel hold". This might also avoid some unpleasant surprises :)
+! on this. It will definitely cause some confusion in our system, too, as it currently stands.
Created attachment 47898 [details] [review] Bug 15670 - Rename "Cancel" to "Cancel hold" when checking in a waiting item When checking in an on-hold item which is waiting, the "Cancel" button cancels the hold, so it should say so. This patch changes the text. This patch also moves the 'cancel hold' button to the middle, on the theory that buttons on the left should default to 'confirm' and buttons on the right should generally imply 'cancel'--as in 'do nothing.' Moving it to the middle seems like a good place to put it where users will have to think about clicking it. To test: 1. Find an hold which has been made 'waiting,' or check in an confirm a pending hold at your library. 2. Check in that item again and verify that the 'Hold found' dialog contains a 'Cancel hold' button which works to cancel the waiting hold. 3. Repeat the process and confirm that the functionality of the other buttons is unchanged.
Created attachment 47935 [details] [review] Bug 15670 - Rename "Cancel" to "Cancel hold" when checking in a waiting item When checking in an on-hold item which is waiting, the "Cancel" button cancels the hold, so it should say so. This patch changes the text. This patch also moves the 'cancel hold' button to the middle, on the theory that buttons on the left should default to 'confirm' and buttons on the right should generally imply 'cancel'--as in 'do nothing.' Moving it to the middle seems like a good place to put it where users will have to think about clicking it. To test: 1. Find an hold which has been made 'waiting,' or check in an confirm a pending hold at your library. 2. Check in that item again and verify that the 'Hold found' dialog contains a 'Cancel hold' button which works to cancel the waiting hold. 3. Repeat the process and confirm that the functionality of the other buttons is unchanged. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 47949 [details] [review] Bug 15670 - Rename "Cancel" to "Cancel hold" when checking in a waiting item When checking in an on-hold item which is waiting, the "Cancel" button cancels the hold, so it should say so. This patch changes the text. This patch also moves the 'cancel hold' button to the middle, on the theory that buttons on the left should default to 'confirm' and buttons on the right should generally imply 'cancel'--as in 'do nothing.' Moving it to the middle seems like a good place to put it where users will have to think about clicking it. To test: 1. Find an hold which has been made 'waiting,' or check in an confirm a pending hold at your library. 2. Check in that item again and verify that the 'Hold found' dialog contains a 'Cancel hold' button which works to cancel the waiting hold. 3. Repeat the process and confirm that the functionality of the other buttons is unchanged. Followed test plan, works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to Master - Should be in the May 2016 Release. Thanks!
Patch pushed to stable, will be in 3.22.5