The 'Show/hide columns' button for changing the columns on a table configured under administration > columns configuration is not translatable.
Would it be better to say something like 'Toggle columns'? What kind of change do you think is best?
Hi Aleisha, the problem is not the wording - the strings don't seem to show up in the po files so they can't be translated and remain in English. Actually finding a not too long translation in German will be the next problem then :)
Oh I see :-) Will leave for someone with a bit more knowledge of the po files etc to work on
Would be nice to see this fixed.
Based on the documentation this should be a simple fix: http://datatables.net/extensions/colvis/options "buttonText: 'Select columns'" However I'm unfamiliar with the colVis configuration system so it's not obvious to me where that setting should go.
Created attachment 48428 [details] [review] Bug 15674: Make "Column visibility" translatable The "Column visibility" text button was not translatable, now it is. Test plan: 1/ Update the template for a given language and translate the "Column visibility" string 2/ Go on admin/currency.pl => The string should be translated.
Created attachment 48483 [details] [review] [SIGNED-OFF] Bug 15674: Make "Column visibility" translatable The "Column visibility" text button was not translatable, now it is. Test plan: 1/ Update the template for a given language and translate the "Column visibility" string 2/ Go on admin/currency.pl => The string should be translated. Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
The QA tool is complaining :( FAIL koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc FAIL forbidden patterns forbidden pattern: simple-quote string (line 29)
Created attachment 48487 [details] [review] Bug 15674: Use double-quote instead of simple-quote
Created attachment 48525 [details] [review] [PASSED QA] Bug 15674: Make "Column visibility" translatable The "Column visibility" text button was not translatable, now it is. Test plan: 1/ Update the template for a given language and translate the "Column visibility" string 2/ Go on admin/currency.pl => The string should be translated. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 48526 [details] [review] [PASSED QA] Bug 15674: Use double-quote instead of simple-quote Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to Master - Should be in the May 2016 Release. Thanks!
Created attachment 48726 [details] [review] [3.22] Bug 15674: Make "Column visibility" translatable Patch for 3.22.x
Patch pushed to 3.22.x, will be in 3.22.5
This patch has been pushed to 3.20.x, will be in 3.20.10.