When processing offline circulations the column of the results table Action column contains "issue", "return" and possibly something like payment. These values are not translatable. Also: issue should probably be checkout and return should be check-in? :)
Created attachment 51846 [details] [review] Bug 15676 - Actions in pending offline circulation actions are not translatable This patch modifies the offline circulation transaction processing page so that English strings describing actions are processed in the template rather than being output directly from the script. To test, apply the patch and create an offline circulation file containing at least one checkout, one check-in, and one payment. - Upload the file and choose 'Add to offline circulation queue.' - View pending offline circulation actions - In the list of pending actions, the actions column should show "Check out" instead of "issue," "Check in" instead of "return," and "Payment" instead of "payment."
Created attachment 51891 [details] [review] Bug 15676 - Actions in pending offline circulation actions are not translatable This patch modifies the offline circulation transaction processing page so that English strings describing actions are processed in the template rather than being output directly from the script. To test, apply the patch and create an offline circulation file containing at least one checkout, one check-in, and one payment. - Upload the file and choose 'Add to offline circulation queue.' - View pending offline circulation actions - In the list of pending actions, the actions column should show "Check out" instead of "issue," "Check in" instead of "return," and "Payment" instead of "payment." Strings appear as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 52239 [details] [review] Bug 15676 - Actions in pending offline circulation actions are not translatable This patch modifies the offline circulation transaction processing page so that English strings describing actions are processed in the template rather than being output directly from the script. To test, apply the patch and create an offline circulation file containing at least one checkout, one check-in, and one payment. - Upload the file and choose 'Add to offline circulation queue.' - View pending offline circulation actions - In the list of pending actions, the actions column should show "Check out" instead of "issue," "Check in" instead of "return," and "Payment" instead of "payment." Strings appear as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11, thanks Owen!
Pushed in 16.05. Will be in 16.05.01.
Patch pushed to 3.22.x, will be in 3.22.8