Bug 15680 - Fresh install of Koha cannot find any dependencies
Summary: Fresh install of Koha cannot find any dependencies
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low blocker (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on: 6679
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-27 14:26 UTC by Kyle M Hall
Modified: 2019-06-27 09:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15680 - Fresh install of Koha cannot find any dependencies (1.76 KB, patch)
2016-01-27 14:37 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2016-01-27 14:26:11 UTC
It seems that on master, after clearing my database, one can no longer perform a fresh install. Koha seems to fail to find any of the installed Perl modules it depends on.

This happens on master. The latest 3.22 finds the dependencies without a problem.
Comment 1 Kyle M Hall 2016-01-27 14:37:47 UTC
Created attachment 47352 [details] [review]
Bug 15680 - Fresh install of Koha cannot find any dependencies

Fixing the evals in PerlModules.pm to pass perl critic has caused
a regression. If appears that using a block eval will not work here,
at least not in its current form.

Test Plan:
1) Delete your database
2) Run the web installer
3) Note Koha says your dependencies need installed
4) Apply this patch
5) Refresh the page
6) Koha should see your dependencies are installed
Comment 2 Jonathan Druart 2016-01-27 14:49:32 UTC
Kyle, I reproduce the issue, and the patch fixes it.
The weird thing is that the script now passes perlcritic (changes in perlcritic?)
I'd suggest to revert 0e356b214eb049a446a8d089d579775aa49287d7 instead of create a new patch, to make the git log explicit.
Comment 3 Kyle M Hall 2016-01-27 16:13:57 UTC
(In reply to Jonathan Druart from comment #2)
> Kyle, I reproduce the issue, and the patch fixes it.
> The weird thing is that the script now passes perlcritic (changes in
> perlcritic?)
> I'd suggest to revert 0e356b214eb049a446a8d089d579775aa49287d7 instead of
> create a new patch, to make the git log explicit.

That is most odd! I'll take care of that reversion!
Comment 4 Julian Maurice 2016-01-28 08:58:37 UTC
This is needed on 3.22.x too, since bug 6679
Comment 5 Julian Maurice 2016-01-28 08:59:56 UTC
Patch pushed to 3.22.x, will be in 3.22.3
Comment 6 Frédéric Demians 2016-02-12 06:35:40 UTC
This patch has been pushed to 3.20.x, will be in 3.20.9.