Created attachment 47358 [details] sample quotes We can't seem to import quotes anymore. I just did on 3.20, but in 3.22 when the file loads up clicking the 'save' button does nothing. This happens on a few sites.
Created attachment 47404 [details] Goethe quotes without umlaut This file does not contain ä, ö, ü etc. It works. (Encoding is UTF8)
Created attachment 47405 [details] Goethe with umlaut This file contains ä, ö, ü. It can not be saved.
Goethe with umlaut gives the following warning: quotes-upload_ajax.pl: malformed UTF-8 character in JSON string, at character offset 52 (before "\\x{4b34}."],[2,"Goet...") at /usr/share/kohaclone/tools/quotes/quotes-upload_ajax.pl line 44., referer: http://10.0.0.62:8080/cgi-bin/koha/tools/quotes-upload.pl I fixed Nicole's example (not all quotes were put in quotes "" and tried to upload. This is the warning I get: quotes-upload_ajax.pl: Wide character in subroutine entry at /usr/share/kohaclone/tools/quotes/quotes-upload_ajax.pl line 44., referer: http://10.0.0.62:8080/cgi-bin/koha/tools/quotes-upload.pl
Created attachment 47411 [details] [review] Bug 15684: Fix encoding issues with quote upload To verify: - Download attachment 'Goethe with umlaut' from Bug 15684 - Go to Tools > Quote Editor - Click "Import quotes" and select the file - The quotes display in a table. Click 'Sav quotes' - Result: Nothing happens To test: - Apply patch - Repeat steps above - Verify that you get a message '2 quotes saved' and that the quotes are added in to the quotes table - Test with attachment 'sample quotes' as well
Created attachment 47415 [details] [review] Bug 15684: Fix encoding issues with quote upload To verify: - Download attachment 'Goethe with umlaut' from Bug 15684 - Go to Tools > Quote Editor - Click "Import quotes" and select the file - The quotes display in a table. Click 'Sav quotes' - Result: Nothing happens To test: - Apply patch - Repeat steps above - Verify that you get a message '2 quotes saved' and that the quotes are added in to the quotes table - Test with attachment 'sample quotes' as well Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
The patch looks good bug I don't see the quotes in the table after selecting the file. Note that I also get a "Uploads limited to csv. Incorrect filetype: plain/text", I have bypassed forcing the filetype in the tt (+fileType = 'csv';).
(In reply to Jonathan Druart from comment #6) > The patch looks good bug I don't see the quotes in the table after selecting > the file. > Note that I also get a "Uploads limited to csv. Incorrect filetype: > plain/text", I have bypassed forcing the filetype in the tt (+fileType = > 'csv';). The instructions say: The quote uploader accepts standard csv files with two columns: "source","text" This bug does not aim to change this behaviour. I think changing the accepted file type extension and/or the behaviour regarding the quotes should be covered by an other bug.
Created attachment 47463 [details] [review] Bug 15684: Fix encoding issues with quote upload To verify: - Download attachment 'Goethe with umlaut' from Bug 15684 - Go to Tools > Quote Editor - Click "Import quotes" and select the file - The quotes display in a table. Click 'Sav quotes' - Result: Nothing happens To test: - Apply patch - Repeat steps above - Verify that you get a message '2 quotes saved' and that the quotes are added in to the quotes table - Test with attachment 'sample quotes' as well Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to Master - Should be in the May 2016 release. Thanks
Patch pushed to 3.22.x, will be in 3.22.3
This patch has been pushed to 3.20.x, will be in 3.20.9.