Created attachment 47401 [details] [review]
the patch for koha-plack script

hello,

When running koha-plack --enable, the script assumes that there is already a commented line that includes the plack configuration in the apache virtual host's config of the instance. The script would comment out the line :

(from /usr/sbin/koha-plack line 148) :

           sed -i 's:^\s*#\(\s*Include /etc/koha/apache-shared-opac-plack.conf\)$:\1:' "$instancefile"
           sed -i 's:^\s*#\(\s*Include /etc/koha/apache-shared-intranet-plack.conf\)$:\1:' "$instancefile"

For old fashioned installs there is no commented line that includes plack configuration, so the regular expression doesn't match and the script doesn't enable plack. In my config (we've set up koha 3 years ago) i had to add the plack-related line directly in the apache virtual host config.

Since the included files use the ${instance} variable, i had to define that variable as well in my vhost config :

       Define instance myinstancename

(the "Define" keyword is not well documented in the apache docs ; i used
it because SetEnv didn't work).

Instead of commenting out the (possibibly non-existent) plack related lines, it is possible to find where the "/etc/koha/apache-shared-{opac,intranet}.conf" files are included and add the two relevant lines.