To reproduce: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping Field name: subtitle MARC field: 245 MARC subfield: b (or 200$e I think for UNIMARC) 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record"
Created attachment 47410 [details] [review] Bug 15697 - Unnecessary comma between title and subtitle on opac-detail.pl To test: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping (or ensure it exists) Field name: subtitle MARC field: 245 MARC subfield: b 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" 5 - Apply patch 6 - View the record again and note the comma is no longer present. Note: this patch removes the comma only for MARC21 where subtitle is not repeatable. UNIMARC seems to be repeatable and does not include punctuation so I believe this may be needed there.
Created attachment 47517 [details] [review] Bug 15697 - Unnecessary comma between title and subtitle on opac-detail.pl To test: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping (or ensure it exists) Field name: subtitle MARC field: 245 MARC subfield: b 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" 5 - Apply patch 6 - View the record again and note the comma is no longer present. Note: this patch removes the comma only for MARC21 where subtitle is not repeatable. UNIMARC seems to be repeatable and does not include punctuation so I believe this may be needed there.
Created attachment 47524 [details] [review] [SIGNED-OFF]Bug 15697: Unnecessary comma between title and subtitle on opac-detail.pl To test: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping (or ensure it exists) Field name: subtitle MARC field: 245 MARC subfield: b 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" 5 - Apply patch 6 - View the record again and note the comma is no longer present. Note: this patch removes the comma only for MARC21 where subtitle is not repeatable. UNIMARC seems to be repeatable and does not include punctuation so I believe this may be needed there. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Comma removed from title of the window and breadcrumb section
What about NORMARC? I guess it micmics MARC21.
Created attachment 47554 [details] [review] Bug 15697 - [QA Followup] Apply change to NORMARC This patch switches from UNLESS MARC21 to IF UNIMARC - this way changes apply to MARC21 and NORMARC and UNIMARC remains unaffected
(In reply to Jonathan Druart from comment #4) > What about NORMARC? I guess it micmics MARC21. I wasn't certain so erred on leaving as is. Updated patch to use IF UNIMARC instead of UNLESS MARC21
Created attachment 47577 [details] [review] Bug 15697: Unnecessary comma between title and subtitle on opac-detail.pl To test: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping (or ensure it exists) Field name: subtitle MARC field: 245 MARC subfield: b 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" 5 - Apply patch 6 - View the record again and note the comma is no longer present. Note: this patch removes the comma only for MARC21 where subtitle is not repeatable. UNIMARC seems to be repeatable and does not include punctuation so I believe this may be needed there. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Comma removed from title of the window and breadcrumb section Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 47578 [details] [review] Bug 15697 - [QA Followup] Apply change to NORMARC This patch switches from UNLESS MARC21 to IF UNIMARC - this way changes apply to MARC21 and NORMARC and UNIMARC remains unaffected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Joubu: magnuse: could you confirm my comment on bug 15697 comment 4 about NORMARC please? magnuse: Joubu: the qa followup looks good. and yes, marc21 and normarc are very similar in most regards
Created attachment 48341 [details] [review] Bug 15697: Unnecessary comma between title and subtitle on opac-detail.pl To test: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping (or ensure it exists) Field name: subtitle MARC field: 245 MARC subfield: b 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" 5 - Apply patch 6 - View the record again and note the comma is no longer present. Note: this patch removes the comma only for MARC21 where subtitle is not repeatable. UNIMARC seems to be repeatable and does not include punctuation so I believe this may be needed there. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Comma removed from title of the window and breadcrumb section Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48342 [details] [review] Bug 15697 - [QA Followup] Apply change to NORMARC This patch switches from UNLESS MARC21 to IF UNIMARC - this way changes apply to MARC21 and NORMARC and UNIMARC remains unaffected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master! Should be in Koha 3.24, thanks Nick!
Patches pushed to 3.22.x, will be in 3.22.5
This patch has been pushed to 3.20.x, will be in 3.20.10.