Created attachment 47416 [details] [review] Bug 15699 - Course reserves instructors should be in form "Surname, Firstname" for sorting purposes This patch changes the order of the name fields and adds a span class around each in case of library wanting to customize further To test: 1 - Enable course reserves 2 - Add some courses with instrcutors 3 - Note they are of form "Firstname Surname" 4 - Apply patch 5 - Note the change 6 - Note span tags 7 - Note you can hide firstname by adding to intranet user js: $(".instr_firstname, instr_separator").hide();
Created attachment 47423 [details] [review] Bug 15699 - Course reserves instructors should be in form "Surname, Firstname" for sorting purposes This patch changes the order of the name fields and adds a span class around each in case of library wanting to customize further To test: 1 - Enable course reserves 2 - Add some courses with instrcutors 3 - Note they are of form "Firstname Surname" 4 - Apply patch 5 - Note the change 6 - Note span tags 7 - Note you can hide firstname by adding to intranet user js: $(".instr_firstname, instr_separator").hide(); Sing-off note: This patch displays the names as advertised on cgi-bin/koha/opac-course-reserves.pl Sorting the names would need some more actions but seems not to be intended by this patch. Signed-off-by: Marc Véron <veron@veron.ch>
"firstname, surname" is the form we usually use to display a patron name. I am not sure about this change, ccing Owen and Katrin to get some feedbacks.
Hm, not sure if I am confused, but firstname surname or surname, firstname For sorting and in general I prefer definitely the latter :) Ideally the code should check for the existance of firstname, as we also have organisations where this field will remain empty (not displayed in the patron form even). So I'd say something like: surname[if firstname], firstname[end]
(In reply to Katrin Fischer from comment #4) (...) > Ideally the code should check for the existance of firstname, as we also > have organisations where this field will remain empty (not displayed in the > patron form even). > > So I'd say something like: > > surname[if firstname], firstname[end] Katrin, I missed that while signing off because it is about instructors / teachers who normally schould have first names :-) ...but you are right, it makes sense to display the firstname only if there is a first name.
Maybe a faculty or work group account? (quote 123 :) )
(In reply to Katrin Fischer from comment #6) > Maybe a faculty or work group account? (quote 123 :) ) Or even kind of room reservation...
Libraries... who knows :) Not a blocker.
ping Nick?
Created attachment 47513 [details] [review] Bug 15699 [QA followup] - Only display firstname if present
Created attachment 47545 [details] [review] Bug 15699 - Course reserves instructors should be in form "Surname, Firstname" for sorting purposes This patch changes the order of the name fields and adds a span class around each in case of library wanting to customize further To test: 1 - Enable course reserves 2 - Add some courses with instrcutors 3 - Note they are of form "Firstname Surname" 4 - Apply patch 5 - Note the change 6 - Note span tags 7 - Note you can hide firstname by adding to intranet user js: $(".instr_firstname, instr_separator").hide(); Sing-off note: This patch displays the names as advertised on cgi-bin/koha/opac-course-reserves.pl Sorting the names would need some more actions but seems not to be intended by this patch. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 47546 [details] [review] Bug 15699 [QA followup] - Only display firstname if present Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 Release. Thanks
Patches pushed to 3.22.x, will be in 3.22.5
This patch has been pushed to 3.20.x, will be in 3.20.10.