Bug 15717 - Installer: Step 3 has HTML tag br showing
Summary: Installer: Step 3 has HTML tag br showing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Mark Tompsett
QA Contact: Testopia
URL:
Keywords:
Depends on: 13618
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-01 19:25 UTC by Mark Tompsett
Modified: 2020-01-06 20:15 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15717: Installer: Step 3 has <br /> showing (3.96 KB, patch)
2016-02-01 19:30 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 15717: Installer: Step 3 has <br /> showing (4.02 KB, patch)
2016-02-01 19:57 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15717: Installer: Step 3 has <br /> showing (4.09 KB, patch)
2016-02-02 09:43 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Tompsett 2016-02-01 19:25:46 UTC
Sample patron types and categories: 

Type: Categories:

Adult patron - default patron type
PT - Patron
ST - Student
BH - Homebound

Child - patron with a guarantor
K - Kid
J - Juvenile
YA - Young Adult

Organization - patron is an institution, not a person
ILL - Inter-library Loan
SC - School
L - Library

Professional - a member of an organization (organization is guarantor)
T - Teacher
S - Staff
B - Board

Imagine that all bunched up with <br />'s instead of actual line feeds.
Comment 1 Mark Tompsett 2016-02-01 19:30:05 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2016-02-01 19:33:44 UTC
NOTE: I suspect it has to do with Template::Stash::AutoEscaping from bug 13618.
Comment 3 Mark Tompsett 2016-02-01 19:34:20 UTC
NOTE: I had to cpan2deb Template::Stash::AutoEscaping to get my master to work.
Comment 4 Nick Clemens 2016-02-01 19:57:12 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-02-02 09:43:40 UTC
Created attachment 47536 [details] [review]
Bug 15717: Installer: Step 3 has <br /> showing

The step to install optional/mandatory things is broken with
many <br />'s instead of line breaks.

TEST PLAN
---------
1) Back up database
2) Drop database
3) Create empty database
4) Run web installer
   -- Notice that step 3 has ugly <br />'s at the last
      part of step 3.
5) Apply patch
6) Repeat steps 2-4
   -- Notice the <br />'s are now nice line breaks.
   NOTE: No promises of perfect positioning!
7) Run koha qa test tools.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Jonathan Druart 2016-02-12 09:38:58 UTC
Depends on bug 13618, which has been reverted from master.
Comment 7 Nick Clemens 2018-08-17 17:23:55 UTC
Awesome work all

Pushed to master for 18.11