This problem was discovered the hard way: Drop DB Create DB Webinstaller run until the screen says: We are ready to do some basic configuration. Please install basic configuration settings to continue the installation. The error log file will contain an error about splitting an uninitialized value. Apply the patch Drop DB Create DB Webinstaller run until the screen says: We are ready to do some basic configuration. Please install basic configuration settings to continue the installation. The error log file will not contain that error.
Created attachment 47533 [details] [review] Bug 15719: Silence warning in C4/Language.pm during web install Test empty database case. TEST PLAN --------- 1) prove -v t/Languages.t -- success (because test case is missing) 2) Apply this patch 3) prove -v t/Languages.t -- success, but warning printed. 4) run koha qa test tools
Created attachment 47534 [details] [review] Bug 15719: Silence warning in C4/Language.pm during web install This problem was discovered the hard way: - Drop DB - Create DB - Webinstaller run until the screen is: We are ready to do some basic configuration. Please install basic configuration settings to continue the installation. -- The error log file will end with an error about splitting an uninitialized value. TEST PLAN --------- 0) First patch already applied 1) prove -v t/Languages.t -- success, but warn prints 2) Apply this patch 3) prove -v t/Languages.t -- success without warning messages 4) run koha qa test tools
Created attachment 47744 [details] [review] [SIGNED-OFF]Bug 15719: Silence warning in C4/Language.pm during web install Test empty database case. TEST PLAN --------- 1) prove -v t/Languages.t -- success (because test case is missing) 2) Apply this patch 3) prove -v t/Languages.t -- success, but warning printed. 4) run koha qa test tools Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. QA test tools rus OK
Created attachment 47745 [details] [review] Bug 15719: Silence warning in C4/Language.pm during web install This problem was discovered the hard way: - Drop DB - Create DB - Webinstaller run until the screen is: We are ready to do some basic configuration. Please install basic configuration settings to continue the installation. -- The error log file will end with an error about splitting an uninitialized value. TEST PLAN --------- 0) First patch already applied 1) prove -v t/Languages.t -- success, but warn prints 2) Apply this patch 3) prove -v t/Languages.t -- success without warning messages 4) run koha qa test tools Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. QA test tools run OK
Created attachment 47806 [details] [review] Bug 15719: Silence warning in C4/Language.pm during web install - tests Test empty database case. TEST PLAN --------- 1) prove -v t/Languages.t -- success (because test case is missing) 2) Apply this patch 3) prove -v t/Languages.t -- success, but warning printed. 4) run koha qa test tools Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. QA test tools rus OK Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 47807 [details] [review] Bug 15719: Silence warning in C4/Language.pm during web install This problem was discovered the hard way: - Drop DB - Create DB - Webinstaller run until the screen is: We are ready to do some basic configuration. Please install basic configuration settings to continue the installation. -- The error log file will end with an error about splitting an uninitialized value. TEST PLAN --------- 0) First patch already applied 1) prove -v t/Languages.t -- success, but warn prints 2) Apply this patch 3) prove -v t/Languages.t -- success without warning messages 4) run koha qa test tools Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. QA test tools run OK Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Much more readable (IMO) would have been my @languages = C4::Context->preference($preference_to_check) ? split /,/, C4::Context->preference($preference_to_check) : ()
(In reply to Jonathan Druart from comment #7) > Much more readable (IMO) would have been > my @languages = C4::Context->preference($preference_to_check) > ? split /,/, C4::Context->preference($preference_to_check) > : () Perhaps, though double function/method calls are slower. :)
Pushed to Master - Should be in the May 2016 Release. Thanks
Patches pushed to 3.22.x, will be in 3.22.5
This patch has been pushed to 3.20.x, will be in 3.20.10.