Bug 15730 - 500 error on returns.pl if barcode doesn't exist
Summary: 500 error on returns.pl if barcode doesn't exist
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on: 14828
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-03 15:58 UTC by Kyle M Hall
Modified: 2016-12-05 21:23 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15730 - 500 error on returns.pl if barcode doesn't exist (1.61 KB, patch)
2016-02-03 15:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15730 - 500 error on returns.pl if barcode doesn't exist (1.68 KB, patch)
2016-02-04 02:39 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15730 - 500 error on returns.pl if barcode doesn't exist (1.73 KB, patch)
2016-02-04 09:18 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2016-02-03 15:58:19 UTC
If a librarian enters a barcode that does not match an item in the database, a 500 error will be displayed instead of the "No item with barcode" message.
Comment 1 Kyle M Hall 2016-02-03 15:59:43 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2016-02-04 02:39:38 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-02-04 09:18:56 UTC
Created attachment 47637 [details] [review]
Bug 15730 - 500 error on returns.pl if barcode doesn't exist

If a librarian enters a barcode that does not match an item in the
database, a 500 error will be displayed instead of the "No item with
barcode" message.

Test Plan:
1) Enter an invalid barcode on returns.pl
2) Note the 500 error
3) Apply this patch
4) Repeat setp 1
5) Note the "No item with barcode" message

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-02-23 21:33:29 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 5 Julian Maurice 2016-03-07 10:04:27 UTC
Does not concern stable versions, status changed to RESOLVED