Bug 15782 - Paging on comments moderation broken
Summary: Paging on comments moderation broken
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: 3.20
Hardware: All All
: P5 - low normal (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-10 10:34 UTC by Katrin Fischer
Modified: 2017-06-14 22:12 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2016-02-10 10:34:20 UTC
When you have more than a "page" of comments already moderated (possibly also with 'to moderate'), a paging option is shown at the bottom. But instead of moving you to the next page, it will move you by one comment entry, which is not the expected behaviour and makes it really hard to use for systems with a lot of comments.

Example:
a
b
c
d
...

Use > to navigate to the next page
b 
c
d
e
...
Comment 1 Marc Véron 2016-02-17 10:06:48 UTC
I can not reproduce the issue on curent master. 
Tested with about 50 comments / 3 "pages".
Comment 2 Katrin Fischer 2016-02-17 10:08:36 UTC
Interesting. I have tested it serveral times now for the library, but couldn't see it in the very beginning. Can you check the offset parameter in the pagination links maybe? In the library reporting they change by 1. If I manipulate the offset parameter in the URL, it works to make bigger 'jumps'.
Comment 3 Marc Véron 2016-02-17 10:23:35 UTC
URL for 1st page:
.../cgi-bin/koha/reviews/reviewswaiting.pl?status=1&page=1

URL for the 2nd page:
.../cgi-bin/koha/reviews/reviewswaiting.pl?status=1&page=2

URL for 3rd page:
.../cgi-bin/koha/reviews/reviewswaiting.pl?status=1&page=3
Comment 4 Katrin Fischer 2016-02-17 10:28:10 UTC
Interesting! The parameter is offset in this version (3.18) - I will recheck on master. Thx for testing!
Comment 5 Jonathan Druart 2016-05-02 19:49:43 UTC
Is this fixed?
Comment 6 Owen Leonard 2016-06-21 12:16:41 UTC
Confirmed in 3.18.x. And 3.20.x. Not an issue in 3.22.x or master. I'm switching the version of this bug to 3.20.x since 3.18.x has no maintainer.
Comment 7 Katrin Fischer 2016-08-14 14:45:22 UTC
I think this can be closed - 3.20 will mostly get security fixes at this point in time. Thx a lot Owen for testing this out!