Bug 15808 - Remove "Return to where you were before" from sysprefs
Summary: Remove "Return to where you were before" from sysprefs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Marc Véron
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-12 08:19 UTC by Marc Véron
Modified: 2017-06-14 22:10 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15808 - Remove "Return to where you were before" from sysprefs (1.43 KB, patch)
2016-02-12 09:23 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15808 - Remove "Return to where you were before" from sysprefs (1.53 KB, patch)
2016-02-12 09:43 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2016-02-12 08:19:18 UTC
See comments on Bug 15776

Description:
Go to Admin - System Preferences
Click on any tab except for Acquisitions (since this is the default tab to go to)
Do a search in the sysprefs toolbar with spelling mistakes so that it will return no results and you are taken to the Acquisitions tab
Click the 'Return to where you were before link' in the error message
Notice you stay on the Acquisitions tab, which is not where you were before

#4
Returning to where I was before, is actually just the tab where I am already.
Note that it does not work for Local use (another script).
Could you not just remove this link? Just display the alert. Nothing more..
Comment 1 Marc Véron 2016-02-12 09:23:02 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2016-02-12 09:43:50 UTC
Created attachment 47955 [details] [review]
Bug 15808 - Remove "Return to where you were before" from sysprefs

This patch removes the link 'return to where you were before' from
syspref search result page after failing search.

To test:
- Apply patch
- Go to System preferences in staff client, do a search
  with something that does not exist
- Verify that a message pops up that does not contain the link.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2016-02-12 09:45:07 UTC
Viewing this patch as a qa follow-up for 15776.
Passed QA
Comment 4 Brendan Gallagher 2016-02-24 01:48:47 UTC
pushed to master - Should be in the May 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-03-07 12:37:47 UTC
Patch pushed to 3.22.x, will be in 3.22.5
Comment 6 Frédéric Demians 2016-03-15 09:02:43 UTC
This patch has been pushed to 3.20.x, will be in 3.20.10.