Deleting a Patron from a batch the following popup may hold the following text: "Are you sure you want to remove card number(s):1 from this batch?" In the example above however a Patron was chosen for deletion with borrowernumber 2, cardnumber "BB1" which aktuall occupied position 1 in the batch list! Index position (here 1) should not be termed card number. To avoid the incorrect naming the message could be changed.. However I'd prefer to skip this message altogether – do it the unix way: No comment on regular operation!
Created attachment 62342 [details] [review] Bug 15815: Reword confirm message when removing patrons from card batch This patch rewords the confirm message when removing patrons from a card batch. From: "Are you sure you want to remove card number(s):1 from this batch?" To: "Are you sure you want to remove the selected patron(s) from this batch?" To test: 1) Go to Tools -> Patron Card Creator -> Manage batches 2) Edit a batch 3) Select one or more patrons and click 'Remove selected patrons' (not individual Delete buttons) 4) Confirm the message is worded better and easier to understand 5) Click OK and confirm the patrons are deleted as expected Sponsored-by: Catalyst IT
Created attachment 62469 [details] [review] [SIGNED-OFF] Bug 15815: Reword confirm message when removing patrons from card batch This patch rewords the confirm message when removing patrons from a card batch. From: "Are you sure you want to remove card number(s):1 from this batch?" To: "Are you sure you want to remove the selected patron(s) from this batch?" To test: 1) Go to Tools -> Patron Card Creator -> Manage batches 2) Edit a batch 3) Select one or more patrons and click 'Remove selected patrons' (not individual Delete buttons) 4) Confirm the message is worded better and easier to understand 5) Click OK and confirm the patrons are deleted as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Aleisha, labels and patron cards scripts are very tied, I think we should apply the same change to labels/label-edit-batch.tt
Created attachment 62602 [details] [review] Bug 15815: Reword confirm message when removing patrons from card batch This patch rewords the confirm message when removing patrons from a card batch. From: "Are you sure you want to remove card number(s):1 from this batch?" To: "Are you sure you want to remove the selected patron(s) from this batch?" To test: 1) Go to Tools -> Patron Card Creator -> Manage batches 2) Edit a batch 3) Select one or more patrons and click 'Remove selected patrons' (not individual Delete buttons) 4) Confirm the message is worded better and easier to understand 5) Click OK and confirm the patrons are deleted as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Aleisha!
This patch has been pushed to 16.11.x and will be in 16.11.08. Wording change - tiny enough for backporting :)
(In reply to Katrin Fischer from comment #6) > This patch has been pushed to 16.11.x and will be in 16.11.08. > > Wording change - tiny enough for backporting :) ditto ^ :0) Pushed to 16.05.x, for 16.05.13 release