Created attachment 48085 [details] upload patron images See attachment - Uses tiny text and input field. Should be bigger
Created attachment 48148 [details] [review] Bug 15828 - Upload patron images is hard to read The styling of the patron image upload form causes the text to be smaller than it should be for the main body of a page. This patch revises the form style and cleans up the markup a bit. This patch also adds client-side validation of the form so that a file upload is required, and a card number is required if an image file is selected. To test, apply the patch and go to Tools -> Upload patron images. 1. Confirm that the text in the form is the correct size. 2. With "Zip file" selected, confirm that submitting the form is blocked and the file upload marked as required. 3. With "Image file" selected, confirm that submitting the form with an empty card number field is blocked and the card number field is marked as required. 4. Confirm that uploading zip files and single images still works correctly. https://bugs.koha-community.org/show_bug.cgi?id=15282
Created attachment 48149 [details] [review] [SIGNED-OFF]Bug 15828: Upload patron images is hard to read The styling of the patron image upload form causes the text to be smaller than it should be for the main body of a page. This patch revises the form style and cleans up the markup a bit. This patch also adds client-side validation of the form so that a file upload is required, and a card number is required if an image file is selected. To test, apply the patch and go to Tools -> Upload patron images. 1. Confirm that the text in the form is the correct size. 2. With "Zip file" selected, confirm that submitting the form is blocked and the file upload marked as required. 3. With "Image file" selected, confirm that submitting the form with an empty card number field is blocked and the card number field is marked as required. 4. Confirm that uploading zip files and single images still works correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised
Comment on attachment 48149 [details] [review] [SIGNED-OFF]Bug 15828: Upload patron images is hard to read Review of attachment 48149 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/picture-upload.tt @@ +129,5 @@ > + <li id="cardnum"> > + [% ELSE %] > + <li id="cardnum" style="display: none"> > + [% END %] > + <label for="cardnumber" class="required">Enter patron cardnumber: </label> Are you sure you wanted to add the required class to the label?
Created attachment 48273 [details] [review] Bug 15828: Upload patron images is hard to read The styling of the patron image upload form causes the text to be smaller than it should be for the main body of a page. This patch revises the form style and cleans up the markup a bit. This patch also adds client-side validation of the form so that a file upload is required, and a card number is required if an image file is selected. To test, apply the patch and go to Tools -> Upload patron images. 1. Confirm that the text in the form is the correct size. 2. With "Zip file" selected, confirm that submitting the form is blocked and the file upload marked as required. 3. With "Image file" selected, confirm that submitting the form with an empty card number field is blocked and the card number field is marked as required. 4. Confirm that uploading zip files and single images still works correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48274 [details] [review] Bug 15828: Remove the required class on label Otherwise the label is red and a bit agressive :) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
> Otherwise the label is red and a bit agressive :) I realize it's odd to see a single label with the required class rather than one among other non-required fields, but it is the class we use for required field labels. See for example the patron entry form. I think that for consistency's sake it should be used.
Pushed to Master - Should be in the May 2016 Release. Thanks.