In the datatable of pending reserves, if a title has several branches, this cause duplicates in the filter select.
Created attachment 48141 [details] [review] Bug 15832 - Fix items split-up in pendingreserves.tt
Created attachment 48497 [details] [review] Bug 15832 - Fix items split-up in pendingreserves.tt Test plna: - Go to circ/pendingreserves.pl (Ensure that there are biblios with many items on different branches), -check the libraries filter at the bottom of datatable. There should be duplicates. - Apply this patch and return to circ/pendingreserves.pl, - libraries filter should not contain duplicate.
Created attachment 48694 [details] [review] Bug 15832 - Fix items split-up in pendingreserves.tt Test plna: - Go to circ/pendingreserves.pl (Ensure that there are biblios with many items on different branches), -check the libraries filter at the bottom of datatable. There should be duplicates. - Apply this patch and return to circ/pendingreserves.pl, - libraries filter should not contain duplicate. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>
The patch removes the duplicates but does not fix the filter. If you have: ---- L1 L2 ---- L1 ---- L2 L3 and you select the L2 filter, you will only see the 3rd line if you select L3, all lines will be hidden.
Tested this on a customer's system at 3.22. The duplicate libraries still display.
Created attachment 49682 [details] [review] Bug 15832 - Fix filter and items split-up in pendingreserves.tt Test plan: - Go to circ/pendingreserves.pl (Ensure that there are biblios with many items on different branches), -check the libraries filter at the bottom of datatable. There should be duplicates. - Apply this patch and return to circ/pendingreserves.pl, - check that libraries filter should not contain duplicate, - check that the filter works.
Created attachment 49870 [details] [review] [SIGNED-OFF] Bug 15832 - Fix filter and items split-up in pendingreserves.tt Test plan: - Go to circ/pendingreserves.pl (Ensure that there are biblios with many items on different branches), - Check the libraries filter at the bottom of datatable. There should be duplicates. - Apply this patch and return to circ/pendingreserves.pl, - check that libraries filter should not contain duplicate, - check that the filter works. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 49892 [details] [review] Bug 15832 - Fix filter and items split-up in pendingreserves.tt Test plan: - Go to circ/pendingreserves.pl (Ensure that there are biblios with many items on different branches), - Check the libraries filter at the bottom of datatable. There should be duplicates. - Apply this patch and return to circ/pendingreserves.pl, - check that libraries filter should not contain duplicate, - check that the filter works. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 49893 [details] [review] Bug 15832: Remove empty string from the filters On each cell, the split will generate a new empty entry. This patch removes that entry. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 Release. Thanks !
Patches pushed to 3.22.x, will be in 3.22.6
Pushed to 3.22.x, will be in 3.20.11.