On renew.pl, the confirmation dialog which appears when you have successfully renewed something includes a link to the item, but a bad value is being passed to the template as part of that link: /cgi-bin/koha/catalogue/moredetail.pl?itemnumber=11157&biblionumber=5433&bi=Koha::Schema::Result::Biblioitem=HASH(0x8a58338)#item11157
Created attachment 48143 [details] [review] Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object 2 links are wrong on the renew page, because item.biblioitemnumber does not return the biblioitemnumber as expect the template. Test plan: Renew an item and check the item link. It should contain a valid biblioitemnumber for the 'bi' parameter.
Created attachment 48146 [details] [review] [SIGNED-OFF] Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object 2 links are wrong on the renew page, because item.biblioitemnumber does not return the biblioitemnumber as expect the template. Test plan: Renew an item and check the item link. It should contain a valid biblioitemnumber for the 'bi' parameter. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 48227 [details] [review] Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object 2 links are wrong on the renew page, because item.biblioitemnumber does not return the biblioitemnumber as expect the template. Test plan: Renew an item and check the item link. It should contain a valid biblioitemnumber for the 'bi' parameter. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Link repaired. At first glance, I am wondering if biblioitemnumber is of actual use here; is it only passed back and forth between script and template?
Pushed to Master - should be in the May 2016 release - thanks!
Patch pushed to 3.22.x, will be in 3.22.5
This patch has been pushed to 3.20.x, will be in 3.20.10.