Bug 15833 - Bad variable value in renewal template confirmation dialog
Summary: Bad variable value in renewal template confirmation dialog
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL: /cgi-bin/koha/circ/renew.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-16 15:46 UTC by Owen Leonard
Modified: 2017-06-14 22:12 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object (2.93 KB, patch)
2016-02-16 16:00 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object (3.03 KB, patch)
2016-02-16 16:57 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object (3.23 KB, patch)
2016-02-19 11:08 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-02-16 15:46:36 UTC
On renew.pl, the confirmation dialog which appears when you have successfully renewed something includes a link to the item, but a bad value is being passed to the template as part of that link:

/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=11157&biblionumber=5433&bi=Koha::Schema::Result::Biblioitem=HASH(0x8a58338)#item11157
Comment 1 Jonathan Druart 2016-02-16 16:00:42 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2016-02-16 16:57:20 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2016-02-19 11:08:45 UTC
Created attachment 48227 [details] [review]
Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object

2 links are wrong on the renew page, because item.biblioitemnumber does
not return the biblioitemnumber as expect the template.

Test plan:
Renew an item and check the item link.
It should contain a valid biblioitemnumber for the 'bi' parameter.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Link repaired. At first glance, I am wondering if biblioitemnumber is
of actual use here; is it only passed back and forth between script and
template?
Comment 4 Brendan Gallagher 2016-02-23 22:22:25 UTC
Pushed to Master - should be in the May 2016 release - thanks!
Comment 5 Julian Maurice 2016-03-07 10:29:15 UTC
Patch pushed to 3.22.x, will be in 3.22.5
Comment 6 Frédéric Demians 2016-03-15 08:59:00 UTC
This patch has been pushed to 3.20.x, will be in 3.20.10.