Following coding guideline JS8: "Follow guidelines set by JSHint," some errors should be corrected in staff-global.js staff-global.js: line 7, col 73, Missing semicolon. staff-global.js: line 7, col 75, Missing semicolon. staff-global.js: line 16, col 2, Unnecessary semicolon. staff-global.js: line 103, col 13, 'newin' is already defined. staff-global.js: line 125, col 39, Use '===' to compare with '0'. staff-global.js: line 125, col 73, Use '===' to compare with '0'.
Created attachment 48188 [details] [review] Bug 15844 - Correct JSHint errors in staff-global.js This patch corrects minor errors in staff-global.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on staff-global.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Confirm that the "Help" link opens the help window. - Confirm that audio alerts work with local and remote sound files - Confirm that the format() method is still working correctly by, for instance, opening the detail page for a bibliographic record with multiple items and choosing 'Edit -> Delete record' from the menu. The error message should read like "2 item(s) are attached to this record..."
Created attachment 48192 [details] [review] Bug 15844 - Correct JSHint errors in staff-global.js This patch corrects minor errors in staff-global.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on staff-global.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Confirm that the "Help" link opens the help window. - Confirm that audio alerts work with local and remote sound files - Confirm that the format() method is still working correctly by, for instance, opening the detail page for a bibliographic record with multiple items and choosing 'Edit -> Delete record' from the menu. The error message should read like "2 item(s) are attached to this record..." Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. No errors with JSHint CLI (6 errors fixed)
Created attachment 48210 [details] [review] Bug 15844 - Correct JSHint errors in staff-global.js This patch corrects minor errors in staff-global.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on staff-global.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Confirm that the "Help" link opens the help window. - Confirm that audio alerts work with local and remote sound files - Confirm that the format() method is still working correctly by, for instance, opening the detail page for a bibliographic record with multiple items and choosing 'Edit -> Delete record' from the menu. The error message should read like "2 item(s) are attached to this record..." Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. No errors with JSHint CLI (6 errors fixed) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.4