Bug 15845 - Renewal date in circulation.pl is not always correct and not even used
Summary: Renewal date in circulation.pl is not always correct and not even used
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-17 15:32 UTC by Marcel de Rooy
Modified: 2017-06-14 22:10 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15845: Renewal date in circulation.pl is not always correct and not even used (2.01 KB, patch)
2016-02-17 15:37 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 15845: Renewal date in circulation.pl is not always correct and not even used (2.11 KB, patch)
2016-02-22 10:01 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15845: Renewal date in circulation.pl is not always correct and not even used (2.17 KB, patch)
2016-02-22 10:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15845: Do not import Add_Delta_YM from circulation.pl (705 bytes, patch)
2016-02-22 10:51 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2016-02-17 15:32:59 UTC

    
Comment 1 Marcel de Rooy 2016-02-17 15:37:36 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-02-22 10:01:41 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-02-22 10:51:06 UTC
Created attachment 48270 [details] [review]
Bug 15845: Renewal date in circulation.pl is not always correct and not even used

If you have a patron category with a hard renewal date, the enrolllment
period will be zero. You cannot calculate the renewal date as is done
in the script currently.

Even more, the renewaldate template var is not even used.

Test plan:
[1] Verify that checkin/checkout works as expected.
[2] Git grep on renewaldate
[3] Check the code in circulation.pl for "$renew"

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2016-02-22 10:51:09 UTC
Created attachment 48271 [details] [review]
Bug 15845: Do not import Add_Delta_YM from circulation.pl

This subroutine is no longer used in this script.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Brendan Gallagher 2016-02-24 03:04:36 UTC
Pushed to Master - Should be in the May 2016 release. thanks!
Comment 6 Julian Maurice 2016-02-26 15:46:07 UTC
Patch pushed to 3.22.x, will be in 3.22.4