Bug 15863 - When creating a dictionary for date column, date range selection should be hidden if all dates is selected
Summary: When creating a dictionary for date column, date range selection should be hi...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-19 16:13 UTC by Jonathan Druart
Modified: 2016-12-05 21:27 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15863: Show/hide date range selection if not needed - dictionnary (1.67 KB, patch)
2016-02-19 16:15 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15863: Show/hide date range selection if not needed - dictionnary (1.82 KB, patch)
2016-02-19 17:02 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 15863: Show/hide date range selection if not needed - dictionnary (1.89 KB, patch)
2016-04-03 15:01 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-02-19 16:13:25 UTC
When creating a dictionary for a date column, there is a "date range" / "all dates" radio buttons and 2 inputs to select the date range. These inputs should be hidden if "all dates" is selected.

See bug 2669 comment 10 for the request.
Comment 1 Jonathan Druart 2016-02-19 16:15:58 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-02-19 17:02:07 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-04-03 15:01:17 UTC
Created attachment 49826 [details] [review]
[PASSED QA] Bug 15863: Show/hide date range selection if not needed - dictionnary

When creating a dictionary for a date column, there is a "date range" /
"all dates" radio buttons and 2 inputs to select the date range. These
inputs should be hidden if "all dates" is selected.

Test plan:
1/ Create a new dictionary on reports/dictionary.pl
2/ Select a date column (borrowers.dateofbirth of instance)
3/ On step 4, the start/end of the date range inputs should be
hidden/shown depending of the radio buttons.

Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Kyle M Hall 2016-04-29 13:36:49 UTC
Pushed to master for the May 2016 release. Thanks Jonathan!