Bug 15866 - No warning when deleting a rotating collection using the toolbar button
Summary: No warning when deleting a rotating collection using the toolbar button
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-19 17:48 UTC by Owen Leonard
Modified: 2016-12-05 21:25 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15866: Add confirm message for deleting rotating collection from toolbar (2.48 KB, patch)
2016-03-20 23:26 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15866: Add confirm message for deleting rotating collection from toolbar (2.61 KB, patch)
2016-03-21 10:02 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 15866: Add confirm message for deleting rotating collection from toolbar (2.79 KB, patch)
2016-03-23 06:26 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-02-19 17:48:36 UTC
If you are viewing the contents of or adding items to a rotating collection (Tools › Rotating collections › Collection › Add or remove items) clicking the "Delete" button in the toolbar will delete the collection without any client-side or server-side warning.
Comment 1 Aleisha Amohia 2016-03-20 23:26:57 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-03-21 10:02:10 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-03-23 06:26:17 UTC
Created attachment 49424 [details] [review]
[PASSED QA] Bug 15866: Add confirm message for deleting rotating collection from toolbar

To test:
1) Go to Tools -> Rotating Collections
2) Click on any rotating collection ('Add or remove items' from drop down menu)
3) Click 'Delete' from toolbar. Validate you are now asked to confirm your deletion. Check that cancel works, then check that confirm works.

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I've added the word 'rotating' before collection, to make
it clear for translators what is meant here.
Comment 4 Brendan Gallagher 2016-03-23 18:03:01 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-04-07 05:33:57 UTC
Patch pushed to 3.22.x, will be in 3.22.6
Comment 6 Frédéric Demians 2016-04-27 15:38:13 UTC
Pushed to 3.20.x, will be in 3.20.11.