Created attachment 48353 [details] [review] Bug 15909 - Remove the use of makepartialpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button, but make the payment for less then the full amount
Kyle, can you please rebase, it does not apply.
Ah, sorry, depends on the previous one.
Created attachment 52133 [details] [review] Bug 15909 - Remove the use of makepartialpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button, but make the payment for less then the full amount
Created attachment 52153 [details] [review] Bug 15909 - Remove the use of makepartialpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button, but make the payment for less then the full amount
nicolas@plac:~/kohaclone$ git bz apply 15909 Bug 15909 - Remove the use of makepartialpayment 52153 - Bug 15909 - Remove the use of makepartialpayment Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15909 - Remove the use of makepartialpayment fatal: sha1 information is lacking or useless (C4/Accounts.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 15909 - Remove the use of makepartialpayment The copy of the patch that failed is found in: /home/nicolas/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15909---Remove-the-use-of-makepartialpayment-3HVrwB.patch
ha didn't see dependencies, sorry :)
Created attachment 58751 [details] [review] Bug 15909 - Remove the use of makepartialpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button, but make the payment for less then the full amount
Created attachment 58753 [details] [review] Bug 15909 - Remove the use of makepartialpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button, but make the payment for less then the full amount
Created attachment 58756 [details] [review] Bug 15909 - Remove the use of makepartialpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button, but make the payment for less then the full amount Signed-off-by: Laura Slavin <lslavin@hmcpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 58766 [details] [review] Bug 15909 - Remove the use of makepartialpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button, but make the payment for less then the full amount Signed-off-by: Laura Slavin <lslavin@hmcpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05!
This won't get ported back to 16.11.x as it is an enhancement.