Bug 15910 - Move header search keep text JavaScript into staff-global.js
Summary: Move header search keep text JavaScript into staff-global.js
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-24 17:13 UTC by Owen Leonard
Modified: 2017-06-14 22:10 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15910 - Move header search keep text JavaScript into staff-global.js (4.36 KB, patch)
2016-02-24 17:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15910 - Move header search keep text JavaScript into staff-global.js (4.50 KB, patch)
2016-02-25 15:18 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15910 - Move header search keep text JavaScript into staff-global.js (4.57 KB, patch)
2016-02-29 17:06 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-02-24 17:13:02 UTC
Bug 14189 added some global JavaScript to a new include file which is included in doc-head-close.inc. Since it's included globally, there is no reason not to move it to staff-global.js.
Comment 1 Owen Leonard 2016-02-24 17:20:47 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-02-25 15:18:40 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-02-29 17:06:48 UTC
Created attachment 48474 [details] [review]
Bug 15910 - Move header search keep text JavaScript into staff-global.js

Bug 14189 added some global JavaScript to a new include file which is
included in doc-head-close.inc. Since it's included globally, there is
no reason not to move it to staff-global.js. This patch does so.

To test, apply the patch and clear your browser cache if necessary.

- Navigate to any page in the staff client which has multiple header
  search tabs.
- Type something in one of the tabs.
- Switch tabs. Verify that your text was copied to the newly-displayed
  form field.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-02 03:51:32 UTC
Pushed to Master - Should be in the May 2016 Release. Thanks!