There are some markup issues with the patron lists templates which I would like to correct. I'm marking this bug dependent on Bug 15916 because the JS errors will make it hard to test properly.
Created attachment 48466 [details] [review] Bug 15925 - Correct some markup issues with patron lists pages This patch makes some markup changes to the patron lists interface in order to make them more consistent with other areas of Koha. Change to look for when testing: Tools -> Patron lists: - Wrap "New patron list" button in standard <div id="toolbar"> - Place toolbar above page heading. Tools -> Patron lists -> New patron list: - Use built-in form validation for required fields - Clarify page title and breadcrumbs on list add and edit Tools -> Patron lists -> Edit patron list - Use the more standard term "Edit" in place of "Modify" Validation errors have been corrected on all three templates, including removal of an extra </div>.
Created attachment 48467 [details] [review] Bug 15925 [Revised] Correct some markup issues with patron lists pages This patch makes some markup changes to the patron lists interface in order to make them more consistent with other areas of Koha. Change to look for when testing: Tools -> Patron lists: - Wrap "New patron list" button in standard <div id="toolbar"> - Place toolbar above page heading. Tools -> Patron lists -> New patron list: - Use built-in form validation for required fields - Clarify page title and breadcrumbs on list add and edit Validation errors have been corrected on all three templates, including removal of an extra </div>. Revision: I was wrong about the frequency of use of "Modify." There's no clear-cut reason to replace it with "Edit" so I have undone that change.
Created attachment 48607 [details] [review] Bug 15925 [Revised] Correct some markup issues with patron lists pages This patch makes some markup changes to the patron lists interface in order to make them more consistent with other areas of Koha. Change to look for when testing: Tools -> Patron lists: - Wrap "New patron list" button in standard <div id="toolbar"> - Place toolbar above page heading. Tools -> Patron lists -> New patron list: - Use built-in form validation for required fields - Clarify page title and breadcrumbs on list add and edit Validation errors have been corrected on all three templates, including removal of an extra </div>. Revision: I was wrong about the frequency of use of "Modify." There's no clear-cut reason to replace it with "Edit" so I have undone that change. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Works as expected. No regression. Better texts. Consistent validation.
Created attachment 48609 [details] [review] Bug 15925 [Revised] Correct some markup issues with patron lists pages This patch makes some markup changes to the patron lists interface in order to make them more consistent with other areas of Koha. Change to look for when testing: Tools -> Patron lists: - Wrap "New patron list" button in standard <div id="toolbar"> - Place toolbar above page heading. Tools -> Patron lists -> New patron list: - Use built-in form validation for required fields - Clarify page title and breadcrumbs on list add and edit Validation errors have been corrected on all three templates, including removal of an extra </div>. Revision: I was wrong about the frequency of use of "Modify." There's no clear-cut reason to replace it with "Edit" so I have undone that change. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Works as expected. No regression. Better texts. Consistent validation. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 release. Thanks!
Created attachment 48746 [details] [review] [3.22.x] Bug 15925: Correct some markup issues with patron lists pages Patch for 3.22.x
Patch pushed to 3.22.x, will be in 3.22.5