Bug 15946 - Broken link to LoC in MARCXML declaration for OAI-PMH ListMetadataFormats
Summary: Broken link to LoC in MARCXML declaration for OAI-PMH ListMetadataFormats
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Web services (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 16172
  Show dependency treegraph
 
Reported: 2016-03-01 10:01 UTC by Zeno Tajoli
Modified: 2016-12-05 21:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Fix for master (1.63 KB, patch)
2016-03-01 10:50 UTC, Zeno Tajoli
Details | Diff | Splinter Review
Fix for 3.22 (1.57 KB, patch)
2016-03-01 10:50 UTC, Zeno Tajoli
Details | Diff | Splinter Review
Bug 15946 Valid namespace for OAI marcxml schema (1.81 KB, patch)
2016-03-02 06:18 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 15946 Valid namespace for OAI marcxml schema (3.22/3.20) (1.77 KB, patch)
2016-03-02 06:21 UTC, Frédéric Demians
Details | Diff | Splinter Review
[PASSED QA] Bug 15946 Valid namespace for OAI marcxml schema (1.88 KB, patch)
2016-03-20 22:46 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 15946 Valid namespace for OAI marcxml schema (3.22/3.20) (1.83 KB, patch)
2016-03-20 22:49 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Tajoli 2016-03-01 10:01:44 UTC
For OAI-PMH we need to declare an header for the format MARCXML
This  header uses links to Library of Congress site.

Those links are not well written, this error gives you problem with OAI-PMH validators like http://validator.oaipmh.com/.

The problem is present in 3.22 and 3.20 also.
Comment 1 Zeno Tajoli 2016-03-01 10:50:15 UTC Comment hidden (obsolete)
Comment 2 Zeno Tajoli 2016-03-01 10:50:46 UTC Comment hidden (obsolete)
Comment 3 Zeno Tajoli 2016-03-01 10:52:40 UTC
This path fixes the value of xml schema variable and the link
to Library of Congress.
For Dublin Core format those values are defined in UNIMARCslim2OAIDC.xsl
and MARC21slim2OAIDC.xsl.
For MARCXML those values are writte into the code

To test it:
1)Setup OAI-PMH
2)Test the site inserting the BaseURL into http://validator.oaipmh.com
3)See the problem with ListMetadataFormats [link: http://validator.oaipmh.com/#ListMetadataFormats]
4)Insert the patch
5)See the problem is over
Comment 4 Frédéric Demians 2016-03-02 06:18:27 UTC Comment hidden (obsolete)
Comment 5 Frédéric Demians 2016-03-02 06:21:19 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2016-03-20 22:46:36 UTC
Created attachment 49360 [details] [review]
[PASSED QA] Bug 15946 Valid namespace for OAI marcxml schema

This path fixes the value of xml schema variable and the link to Library
of Congress.  For Dublin Core format those values are defined in
UNIMARCslim2OAIDC.xsl and MARC21slim2OAIDC.xsl.  For MARCXML those
values are written into the code

To test it:
1) Setup OAI-PMH
2) Test the site inserting the BaseURL into http://validator.oaipmh.com
3) See the problem with ListMetadataFormats [link:
   http://validator.oaipmh.com/#ListMetadataFormats]
4) Insert the patch
5) See the problem is over

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  Invalid before patch, valid after.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2016-03-20 22:49:35 UTC
Created attachment 49361 [details] [review]
[PASSED QA] Bug 15946 Valid namespace for OAI marcxml schema (3.22/3.20)

As the patch for master, this patch apply on 3.22 (and 3.20 probably).

This path fixes the value of xml schema variable and the link to Library
of Congress.  For Dublin Core format those values are defined in
UNIMARCslim2OAIDC.xsl and MARC21slim2OAIDC.xsl.  For MARCXML those
values are written into the code

To test it:
1) Setup OAI-PMH
2) Test the site inserting the BaseURL into http://validator.oaipmh.com
3) See the problem with ListMetadataFormats [link:
   http://validator.oaipmh.com/#ListMetadataFormats] 4) Insert the patch
5) See the problem is over

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  Invalid before patch, valid after.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Brendan Gallagher 2016-03-22 23:54:31 UTC
Pushed to Master (only the first patch)  @RMaint please notice patch for 3.22 - This should be in the May 2016 Release.  

Thanks!
Comment 9 Julian Maurice 2016-03-23 08:57:51 UTC
(In reply to Brendan Gallagher from comment #8)
> @RMaint please notice patch for 3.22

Noticed! Thanks

Patch pushed to 3.22.x, will be in 3.22.5
Comment 10 Frédéric Demians 2016-03-23 12:52:40 UTC
Pushed to 3.20.x, will be in 3.20.10