Work to do: Include owning library column on the list of checkouts for patrons. Pages needing enhancement: cgi-bin/koha/circ/circulation.pl cgi-bin/koha/members/moremember.pl Seeking Co Sponsors : http://devs.bywatersolutions.com/projects/add-owning-library-column-checkouts/
Created attachment 53399 [details] [review] Bug 15975 - Add Owning Library Column to Checkouts To test: 1 - Checkout some items to a patron 2 - Note there is no 'Owning library' column 3 - Apply patch 4 - Note there IS an 'Owning library' column 5 - Use the columns configuration and ensure you can hide/display column at will Sponsored by: Coeur d'Alene Public Library (http://www.cdalibrary.org/)
Hi Nick, I think this should be 'home library' to fit with our usual terminology, what do you think? It's what we use on the detail page for example.
(In reply to Katrin Fischer from comment #2) > Hi Nick, I think this should be 'home library' to fit with our usual > terminology Agreed.
Created attachment 53550 [details] [review] Bug 15975 - Add Owning Library Column to Checkouts To test: 1 - Checkout some items to a patron 2 - Note there is no 'Owning library' column 3 - Apply patch 4 - Note there IS an 'Owning library' column 5 - Use the columns configuration and ensure you can hide/display column at will Sponsored by: Coeur d'Alene Public Library (http://www.cdalibrary.org/)
Created attachment 53551 [details] Datatable error with patch applied With patch applied, I get a datatable warning whilt checking out: "Requested unknown parameter 'homebranch' for row 0, column 7". See screenshot. Without patch, error does not appear.
Created attachment 53566 [details] [review] Bug 15975 - Add Owning Library Column to Checkouts To test: 1 - Checkout some items to a patron 2 - Note there is no 'Owning library' column 3 - Apply patch 4 - Note there IS an 'Owning library' column 5 - Use the columns configuration and ensure you can hide/display column at will Sponsored by: Coeur d'Alene Public Library (http://www.cdalibrary.org/) Works as expected (after clearing browser cache) Signed-off-by: Marc <veron@veron.ch>
Re-tested with browser cache cleared... Sorry for the noise :-)
Tiny request: please adapt commit message to new column name! I am changing the bug title too as this is used for the release notes!
Created attachment 53580 [details] [review] Bug 15975 - Add Owning Library Column to Checkouts To test: 1 - Checkout some items to a patron 2 - Note there is no 'Home library' column 3 - Apply patch 4 - Note there IS an 'Home library' column 5 - Use the columns configuration and ensure you can hide/display column at will Sponsored by: Coeur d'Alene Public Library (http://www.cdalibrary.org/) Works as expected (after clearing browser cache). Commit message amended (as of comment #7) Signed-off-by: Marc <veron@veron.ch>
Nick, can you check the additional time added by this new join on a relatively big table (100 checkouts displayed)?
With this patch there is a small display error in the table of checkouts: the new column leaves a gap at the end of the last grey line holding the totals and renewal due date. This happens on the checkouts and the details tab.
(In reply to Jonathan Druart from comment #10) > Nick, can you check the additional time added by this new join on a > relatively big table (100 checkouts displayed)? I don't see a real difference at 105 checkouts BEFORE Table in ms (Page in Seconds) 1123 (2.01) 1136 (3.23) 1213 (3.09) 1231 (3.17) 1137 (3.92) 1128 (3.04) 1177 (3.04) 1969 (4.87) 1146 (3.12) 1126 (3.33) AFTER Table in ms (Page in Seconds) 1088 (3.29) 1105 (3.02) 1127 (2.93) 1154 (3.14) 1158 (3.29) 1189 (3.32) 1121 (3.09) 1210 (3.11) 1224 (3.66) 1214 (3.67)
(In reply to Katrin Fischer from comment #11) > With this patch there is a small display error in the table of checkouts: > the new column leaves a gap at the end of the last grey line holding the > totals and renewal due date. > This happens on the checkouts and the details tab. Can you give me a screen shot? I can't recreate this one - once I restart plack and clear cache it looks okay on my end
Created attachment 55583 [details] [review] Bug 15975 (QA Followup) Fix colspan for footer
Created attachment 55655 [details] [review] [PASSED QA] Bug 15975 - Add Owning Library Column to Checkouts To test: 1 - Checkout some items to a patron 2 - Note there is no 'Home library' column 3 - Apply patch 4 - Note there IS an 'Home library' column 5 - Use the columns configuration and ensure you can hide/display column at will Sponsored by: Coeur d'Alene Public Library (http://www.cdalibrary.org/) Works as expected (after clearing browser cache). Commit message amended (as of comment #7) Signed-off-by: Marc <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 55656 [details] [review] [PASSED QA] Bug 15975 (QA Followup) Fix colspan for footer Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 16.11, thanks Nick!