Bug 15981 - Serials frequencies can be deleted without warning
Summary: Serials frequencies can be deleted without warning
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/serials/subscription-fr...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-04 16:45 UTC by Owen Leonard
Modified: 2017-06-14 22:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 15981 - Serials frequencies can be deleted without warning (2.00 KB, patch)
2016-03-04 16:57 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 15981 - Serials frequencies can be deleted without warning (2.02 KB, patch)
2016-03-08 20:35 UTC, Nicole C. Engard 		Details | Diff | Splinter Review
Bug 15981 - Serials frequencies can be deleted without warning (2.09 KB, patch)
2016-03-09 11:03 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-04 16:45:31 UTC 
There is some code in the serials frequencies template for triggering a JavaScript alert to confirm deletion of a frequency, but it is incomplete. You only get a warning about deleting a frequency which is in use by an existing subscription.
Comment 1 Owen Leonard 2016-03-04 16:57:47 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2016-03-08 20:35:43 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-09 11:03:29 UTC 
Created attachment 48842 [details] [review]
Bug 15981 - Serials frequencies can be deleted without warning

A JavaScript alert should ask the user to confirm deletion of a serial
frequency. This patch adds this to the template.

To test, apply the patch and go to Serials -> Manage frequencies

- In the list of frequencies, click any "Delete" link.
- Verify that a JavaScript alert is triggered.
- Test that cancelling the alert cancels the deletion operation.
- Test that confirming the alert allows the deletion to complete.

Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-09 16:44:04 UTC 
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-03-14 09:26:30 UTC 
Patch pushed to 3.22.x, will be in 3.22.5
Comment 6 Frédéric Demians 2016-03-15 09:04:32 UTC 
This patch has been pushed to 3.20.x, will be in 3.20.10.