Bug 13624 definitely broke the master by removing the column `overduerules_transport_type`.`letternumber` from kohastructure.sql. This seems to be a mistake, since we only dropped columns `branchcode` and `categorycode` in the atomicupdate file. This new bug is to keep track of everything made to address this issue. I don't know if we'll start with a patch correcting the master, or if we'll rebase to old patch and move from there.
(In reply to Charles Farmer from comment #0) > I don't know if we'll start with a patch correcting the master, or if we'll > rebase to old patch and move from there. Start from master. It's easier for people to test from that point. :)
Any progress on this?
(In reply to Katrin Fischer from comment #2) > Any progress on this? Not yet. I'll try to make a patch in-between two tasks soon enough
Created attachment 49398 [details] [review] Bug 16007: Adding back column 'letternumber' to table 'overduerules_transport_types' Bug 13624 definitely broke the master by removing the column `overduerules_transport_type`.`letternumber` from kohastructure.sql. This patch aims to fix the problem by adding the column back on systems which had their 'letternumber' removed.
Comment on attachment 49398 [details] [review] Bug 16007: Adding back column 'letternumber' to table 'overduerules_transport_types' Review of attachment 49398 [details] [review]: ----------------------------------------------------------------- Take a look at C4/Members.pm sub columns. I think that is a better way to determine column names. :)
Created attachment 49401 [details] [review] Bug 16007: Adding back column 'letternumber' to table 'overduerules_transport_types' Bug 13624 definitely broke the master by removing the column `overduerules_transport_type`.`letternumber` from kohastructure.sql. This patch aims to fix the problem by adding the column back on systems which had their 'letternumber' removed.
(In reply to M. Tompsett from comment #5) > Take a look at C4/Members.pm sub columns. I think that is a better way to > determine column names. :) That's a much cleaner, less db-dependent way of doing it. I obsoleted my last patch and made a new one. Reviews are welcomed, as always. If I ever fix the patch in 13624, should I post it back there again, somewhere here on this bug, or should we open a new tracker?
Comment on attachment 49401 [details] [review] Bug 16007: Adding back column 'letternumber' to table 'overduerules_transport_types' Review of attachment 49401 [details] [review]: ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/Bug_16007_adding_column_letternumber_back_into_table_overduerules_transport_types.perl @@ +23,5 @@ > + { > + $letternumberExists = 1; > + last; > + } > + } While this would work. Why not use grep? my @letternumber = grep { $_ eq 'letternumber' } @data; if (@letternumber) { print "EXISTS!\n"; } else { print "DIDN'T FIND!\n"; } http://perldoc.perl.org/functions/grep.html
(In reply to M. Tompsett from comment #8) > While this would work. Why not use grep? Silly java coding weekend, why do you make me forget about grep :( Do you want another patch?
(In reply to Charles Farmer from comment #9) > Do you want another patch? If you don't mind, that would be nicer. :)
Created attachment 49402 [details] [review] Bug 16007: Adding back column 'letternumber' to table 'overduerules_transport_types' Bug 13624 definitely broke the master by removing the column `overduerules_transport_type`.`letternumber` from kohastructure.sql. This patch aims to fix the problem by adding the column back on systems which had their 'letternumber' removed.
Created attachment 49403 [details] [review] Bug 16007: Adding back column 'letternumber' to table 'overduerules_transport_types' Bug 13624 definitely broke the master by removing the column `overduerules_transport_type`.`letternumber` from kohastructure.sql. This patch aims to fix the problem by adding the column back on systems which had their 'letternumber' removed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 49404 [details] [review] Schema update In case it is needed.
The previous patch, from 13624, has yet to be corrected. How do I go about this? New tracker, or new patche in #13624 ?
(In reply to Charles Farmer from comment #14) > The previous patch, from 13624, has yet to be corrected. > > How do I go about this? New tracker, or new patche in #13624 ? 13624 is already pushed to master, just wait for this to pass QA and then get pushed. I don't think there is a need to touch 13624 at all. I'm sure a QA person can comment more authoritatively. :)
Created attachment 49455 [details] [review] Bug 16007: Simplify the DB entry - No need to check if the table exists - No need to check if the column exists, just remove the warning
The DB entry is very complicated. I have attached a patch to simplify it. Letting another QAer to have a look.
Upgrading the severity, we need it asap!
Comment on attachment 49404 [details] [review] Schema update No needed, it's the RM job.
Created attachment 49514 [details] [review] [PASSED QA] Bug 16007: Adding back column 'letternumber' to table 'overduerules_transport_types' Bug 13624 definitely broke the master by removing the column `overduerules_transport_type`.`letternumber` from kohastructure.sql. This patch aims to fix the problem by adding the column back on systems which had their 'letternumber' removed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Tested with and without the column in the database - database update didn't throw an error and table was corrected. Thx!
Created attachment 49515 [details] [review] [PASSED QA] Bug 16007: Simplify the DB entry - No need to check if the table exists - No need to check if the column exists, just remove the warning Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to Master - Should be in the May 2016 release. Thanks
Not needed in stable versions, status changed to RESOLVED