It has been decided to remove the $VERSION from our modules. See the discussion on http://koha.1045719.n5.nabble.com/Proposal-Deal-with-modules-versioning-VERSION-td5876752.html
Created attachment 48835 [details] [review] Bug 16011: $VERSION - remove use vars $VERSION perl -p -i -e 's/^(use vars .*)\$VERSION\s?(.*)/$1$2/' **/*.pm
Created attachment 48836 [details] [review] Bug 16011: $VERSION - remove use vars $VERSION perl -p -i -e 's/^(use vars .*)\$VERSION\s?(.*)/$1$2/' **/*.pm
Created attachment 48837 [details] [review] Bug 16011: $VERSION - Remove the $VERSION init Mainly a perl -p -i -e 's/^.*3.07.00.049.*\n//' **/*.pm Then some adjustements
Created attachment 48838 [details] [review] Bug 16011: $VERSION - Remove comments perl -p -i -e 's/^.*set the version for version checking.*\n//' **/*.pm + manual adjustements
Intentionally there is no test plan for this patch set.
Shouldn't be the whole line removed in these files? https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/BackgroundJob.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/ClassSortRoutine/Dewey.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/ClassSortRoutine/Generic.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/ClassSortRoutine/LCC.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/Matcher.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/Members/AttributeTypes.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/Members/Messaging.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/SMS.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/Koha/Borrower/Files.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/Koha/Misc/Files.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/Koha/Template/Plugin/Cache.pm_sec1 For you it's just another regexp I believe ;) Here stayd empty BEGIN block, is it necessary to keep it? Just asking ;) https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=diff#a/C4/BackgroundJob.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=diff#a/C4/Matcher.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=diff#a/C4/Members/AttributeTypes.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=diff#a/C4/Members/Messaging.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=diff#a/Koha/Borrower/Files.pm_sec1
Created attachment 48853 [details] [review] Bug 16011: $VERSION - remove use vars $VERSION perl -p -i -e 's/^(use vars .*)\$VERSION\s?(.*)/$1$2/' **/*.pm
Created attachment 48854 [details] [review] Bug 16011: $VERSION - Remove the $VERSION init Mainly a perl -p -i -e 's/^.*3.07.00.049.*\n//' **/*.pm Then some adjustements
Created attachment 48855 [details] [review] Bug 16011: $VERSION - Remove comments perl -p -i -e 's/^.*set the version for version checking.*\n//' **/*.pm + manual adjustements
Created attachment 48856 [details] [review] Bug 16011: $VERSION - Remove use vars qw(); perl -p -i -e 's/use vars qw\(\);\n//' **/*.pm
Created attachment 48857 [details] [review] Bug 16011: $VERSION - Remove empty BEGIN block perl -p -i -0 -e 's/BEGIN \{\n?\n?\}\n//' **/*.pm
(In reply to Josef Moravec from comment #6) > Shouldn't be the whole line removed in these files? > Here stayd empty BEGIN block, is it necessary to keep it? Just asking ;) Yep agreed! :)
I think there are probably two more use vars qw( ); statements (note the space between parenthesis) in files: Koha/Template/Plugin/Cache.pm C4/SMS.pm
Upon initial review, this looks like it's on the right track and t/db_dependent/00-strict.t passes. I note that Koha::SuggestionEngine::* plugins include a ->VERSION() method, but that's not strictly on point for this particular bug.
Created attachment 48954 [details] [review] Bug 16011: $VERSION - Remove use vars qw(); perl -p -i -e 's/use vars qw\(\s*\);\n//' **/*.pm
Created attachment 48955 [details] [review] Bug 16011: $VERSION - Remove empty BEGIN block perl -p -i -0 -e 's/BEGIN \{\n?\n?\}\n//' **/*.pm
(In reply to Josef Moravec from comment #13) > I think there are probably two more use vars qw( ); statements (note the > space between parenthesis) in files: > > Koha/Template/Plugin/Cache.pm > > C4/SMS.pm Patch amended.
Created attachment 48956 [details] [review] Bug 16011: $VERSION - remove use vars $VERSION perl -p -i -e 's/^(use vars .*)\$VERSION\s?(.*)/$1$2/' **/*.pm Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 48957 [details] [review] Bug 16011: $VERSION - Remove the $VERSION init Mainly a perl -p -i -e 's/^.*3.07.00.049.*\n//' **/*.pm Then some adjustements Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 48958 [details] [review] Bug 16011: $VERSION - Remove comments perl -p -i -e 's/^.*set the version for version checking.*\n//' **/*.pm + manual adjustements Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 48959 [details] [review] Bug 16011: $VERSION - Remove use vars qw(); perl -p -i -e 's/use vars qw\(\s*\);\n//' **/*.pm Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 48960 [details] [review] Bug 16011: $VERSION - Remove empty BEGIN block perl -p -i -0 -e 's/BEGIN \{\n?\n?\}\n//' **/*.pm Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
The QA tools report some problems: FAIL t/Koha/Plugin/Test.pm OK critic OK forbidden patterns OK pod OK spelling FAIL valid Global symbol "$VERSION" requires explicit package name t/Koha/Plugin/Test.pm had compilation errors. FAIL C4/External/BakerTaylor.pm OK critic OK forbidden patterns OK pod OK spelling FAIL valid C4/External/BakerTaylor.pm had compilation errors. Global symbol "$VERSION" requires explicit package name Can you please check?
Created attachment 49387 [details] [review] Bug 16011: Reintroduce $VERSION for 2 pm These files should be managed on their own bug reports.
Created attachment 49441 [details] [review] Bug 16011: $VERSION - remove use vars $VERSION perl -p -i -e 's/^(use vars .*)\$VERSION\s?(.*)/$1$2/' **/*.pm Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Created attachment 49442 [details] [review] Bug 16011: $VERSION - Remove the $VERSION init Mainly a perl -p -i -e 's/^.*3.07.00.049.*\n//' **/*.pm Then some adjustements Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Created attachment 49443 [details] [review] Bug 16011: $VERSION - Remove comments perl -p -i -e 's/^.*set the version for version checking.*\n//' **/*.pm + manual adjustements Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Created attachment 49444 [details] [review] Bug 16011: $VERSION - Remove use vars qw(); perl -p -i -e 's/use vars qw\(\s*\);\n//' **/*.pm Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Created attachment 49445 [details] [review] Bug 16011: $VERSION - Remove empty BEGIN block perl -p -i -0 -e 's/BEGIN \{\n?\n?\}\n//' **/*.pm Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Created attachment 49446 [details] [review] Bug 16011: Reintroduce $VERSION for 2 pm These files should be managed on their own bug reports. Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Pushed to Master - Should be in the May 2016 release. Thanks!
Created attachment 49630 [details] [review] Patch for missing declartaion in BakerTaylor This patch corrects a bug introduced in the last patch with caused BakerTaylor.pm to fail to compile resulting in make test failing. VERSION needed to be declared
Created attachment 49633 [details] [review] Bug 16011 reintroduced VERSION variable needs declaration $VERSION reintroduced into External/BakerTaylor.pm but was not declared. Causes tests to fail. Readd VERSION to the package vars Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Jonathan Druart from comment #33) > Created attachment 49633 [details] [review] [review] > Bug 16011 reintroduced VERSION variable needs declaration > > $VERSION reintroduced into External/BakerTaylor.pm but was > not declared. Causes tests to fail. > Readd VERSION to the package vars > > Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Last patch pushed - Mar 29th 2016