The last time I asked was in 2011 and the staff client was styled very differently then. The last time the file was updated was 2009. Is it safe to delete blue.css now? I don't think we should continue to include a file which is not used by Koha's default configuration.
Created attachment 48861 [details] [review] Bug 16019 - Remove unused blue.css This patch removes blue.css and one image which was used only by blue.css, css_header.png. To test, apply the patch and search Koha files for references to blue.css and css_header.png. There should be none.
Created attachment 48925 [details] [review] Bug 16019 - Remove unused blue.css This patch removes blue.css and one image which was used only by blue.css, css_header.png. To test, apply the patch and search Koha files for references to blue.css and css_header.png. There should be none. Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
I'd suggest to add an update DB entry to check the value of intranetcolorstylesheet. If it contains "blue.css", we empty it and warn the user that it has been removed.
Waiting for an answer.
(In reply to Jonathan Druart from comment #3) > I'd suggest to add an update DB entry to check the value of > intranetcolorstylesheet. If it contains "blue.css", we empty it and warn the > user that it has been removed. I think it's a good idea, but I don't know how to implement it.
Created attachment 49323 [details] [review] Bug 16019: Add a warning in the update DB process if intranetcolorstylesheet=blue.css
Created attachment 49324 [details] [review] Bug 16019 - Remove unused blue.css This patch removes blue.css and one image which was used only by blue.css, css_header.png. To test, apply the patch and search Koha files for references to blue.css and css_header.png. There should be none. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Letting the QA step to another QAer to get another opinion.
Hm, updatedatabase.pl?
Created attachment 49355 [details] [review] [PASSED QA] Bug 16019: Add a warning in the update DB process if intranetcolorstylesheet=blue.css Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 49356 [details] [review] [PASSED QA] Bug 16019 - Remove unused blue.css This patch removes blue.css and one image which was used only by blue.css, css_header.png. To test, apply the patch and search Koha files for references to blue.css and css_header.png. There should be none. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to Master - Should be in the May 2016 release. Thanks!