Bug 16021 - Use Font Awesome icons on automatic item modifications by age page
Summary: Use Font Awesome icons on automatic item modifications by age page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/tools/automatic_item_mo...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-09 14:31 UTC by Owen Leonard
Modified: 2017-06-14 22:05 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 16021 - Use Font Awesome icons on automatic item modifications by age page (4.35 KB, patch)
2016-03-09 14:37 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 16021 - Use Font Awesome icons on automatic item modifications by age page (4.37 KB, patch)
2016-03-09 16:09 UTC, Nicole C. Engard 		Details | Diff | Splinter Review
Bug 16021 - Use Font Awesome icons on automatic item modifications by age page (4.45 KB, patch)
2016-03-10 11:54 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-09 14:31:12 UTC 
The automatic item modifications by age page uses Glyphicons. Font Awesome icons should be used instead.
Comment 1 Owen Leonard 2016-03-09 14:37:45 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2016-03-09 16:09:53 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-10 11:54:35 UTC 
Created attachment 48949 [details] [review]
Bug 16021 - Use Font Awesome icons on automatic item modifications by age page

This patch revises the automatic item modifications by age page to use
Font Awesome icons instead of Glyphicons.

To test, apply the patch and go to Tools -> Automatic item modifications
by age.

- Confirm that the "Edit" toolbar button uses a "pencil" icon instead of
  a "plus." (Edit -> Pencil; Add -> Plus).
- Confirm that the icons associated with adding, editing, or removing
  rules look correct and work correctly.

Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-12 23:26:13 UTC 
Pushed to Master - Should be in the May 2016 release.  Thanks