Bug 16023 - Use Font Awesome icons on audio alerts page
Summary: Use Font Awesome icons on audio alerts page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/audio_alerts.pl
Keywords:
Depends on: 15886
Blocks: 16080
  Show dependency treegraph
 
Reported: 2016-03-09 14:57 UTC by Owen Leonard
Modified: 2017-06-14 22:13 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16023 - Use Font Awesome icons on audio alerts page (2.94 KB, patch)
2016-03-09 15:05 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16023 - Use Font Awesome icons on audio alerts page (3.03 KB, patch)
2016-03-15 15:52 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16023 - Use Font Awesome icons on audio alerts page (3.10 KB, patch)
2016-03-16 10:19 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16023 - Use Font Awesome icons on audio alerts page (3.15 KB, patch)
2016-03-21 03:36 UTC, Mark Tompsett
Details | Diff | Splinter Review
[PASSED QA] Bug 16023 - Use Font Awesome icons on audio alerts page (3.22 KB, patch)
2016-03-21 07:04 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-09 14:57:23 UTC
The audio alerts page uses Glyphicons in a few places. They should be replaced with Font Awesome icons.
Comment 1 Owen Leonard 2016-03-09 15:05:25 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2016-03-09 16:05:15 UTC
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 16023 - Use Font Awesome icons on audio alerts page
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 16023 - Use Font Awesome icons on audio alerts page
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-16023---Use-Font-Awesome-icons-on-audio-alerts-wqIpkQ.patch
Comment 3 Owen Leonard 2016-03-14 12:56:10 UTC
The dependency (Bug 15886) has been pushed to master, so this should apply with no extra steps.
Comment 4 Marc Véron 2016-03-15 15:52:26 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-03-16 10:19:41 UTC Comment hidden (obsolete)
Comment 6 Marc Véron 2016-03-16 10:30:55 UTC
Hi Jonathan, you switched the bug back to Needs Signoff - is that intended?
Comment 7 Mark Tompsett 2016-03-21 03:36:49 UTC Comment hidden (obsolete)
Comment 8 Mark Tompsett 2016-03-21 03:37:37 UTC
(In reply to Marc Véron from comment #6)
> Hi Jonathan, you switched the bug back to Needs Signoff - is that intended?

I don't know. But, it looks like it is fine to me, hence my sign off.
Comment 9 Katrin Fischer 2016-03-21 07:04:30 UTC
Created attachment 49380 [details] [review]
[PASSED QA] Bug 16023 - Use Font Awesome icons on audio alerts page

The audio alerts management page uses Glyphicons in a few places. This
patch replaces them with Font Awesome icons.

To test, apply the patch for Bug 15886 if necessary and enable
the AudioAlerts system preference.

 - Go to Administration -> Audio alerts
 - Confirm that icons for "Edit" and "Delete selected" look correct.
 - Edit an existing alert and confirm that the "play" button looks
   correct and works correctly.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Brendan Gallagher 2016-03-22 00:58:16 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 11 Julian Maurice 2016-04-08 07:11:12 UTC
Patch pushed to 3.22.x, will be in 3.22.6