Bug 16024 - Use Font Awesome icons on item types administration page
Summary: Use Font Awesome icons on item types administration page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/itemtypes.pl?op=a...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-09 15:14 UTC by Owen Leonard
Modified: 2017-06-14 22:07 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16024 - Use Font Awesome icons on item types administration page (1.95 KB, patch)
2016-03-09 15:17 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16024 - Use Font Awesome icons on item types administration page (2.04 KB, patch)
2016-03-10 11:46 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-09 15:14:22 UTC
The item types administration page uses a Glyphicon in one place. It should be replaced with a Font Awesome icon.
Comment 1 Owen Leonard 2016-03-09 15:17:46 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2016-03-10 11:46:08 UTC
Created attachment 48947 [details] [review]
Bug 16024 - Use Font Awesome icons on item types administration page

When editing an item type, a Glyphicon is used for the "translate" link.
It should use a Font Awesome icon instead. This patch corrects it.

To test, apply the patch and go to Administration -> Item types.

- Edit an existing item type.
- Confirm that the icon associated with the "Translate into other
  languages" link is correct.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Brendan Gallagher 2016-03-11 23:00:50 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 4 Julian Maurice 2016-03-14 10:03:10 UTC
Patch pushed to 3.22.x, will be in 3.22.5