Bug 16025 - Use Font Awesome icons on item types localization page
Summary: Use Font Awesome icons on item types localization page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/localization.pl
Keywords:
Depends on:
Blocks: 16080
  Show dependency treegraph
 
Reported: 2016-03-09 15:26 UTC by Owen Leonard
Modified: 2016-12-05 21:25 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16025 - Use Font Awesome icons on item types localization page (2.34 KB, patch)
2016-03-09 15:34 UTC, Owen Leonard
Details | Diff | Splinter Review
Trash icon appears above text (27.90 KB, image/png)
2016-03-15 17:02 UTC, Marc Véron
Details
Bug 16025 [Revised] Use Font Awesome icons on item types localization page (2.49 KB, patch)
2016-03-16 12:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16025 [Revised] Use Font Awesome icons on item types localization page (2.59 KB, patch)
2016-03-16 13:27 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16025 [Revised] Use Font Awesome icons on item types localization page (2.65 KB, patch)
2016-03-17 09:36 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-09 15:26:12 UTC
The item types localization page uses a Glyphicon in one place. It should be replaced with a Font Awesome icon.
Comment 1 Owen Leonard 2016-03-09 15:34:20 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-03-15 17:02:40 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2016-03-16 12:41:54 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2016-03-16 13:27:36 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-03-17 09:36:02 UTC
Created attachment 49249 [details] [review]
Bug 16025 [Revised] Use Font Awesome icons on item types localization page

The item types localization page uses a Glyphicon. This patch converts
it to a Font Awesome icon.

Also changed in this patch: "Delete" text has been added to the delete
link, and a dummy "href" attribute has been added to the link so that it
triggers the right kind of cursor. The deletion confirmation JavaScript
has been edited to ignore the default click action.

To test, apply the patch and go to Administration -> Item types.

- Edit any existing item type and click the "Translate into other
  languages" link.
- If there is not an existing translation, add one. Close the modal
  window and click the "Translate into other languages" link again to
  redisplay it.
- Confirm that there is a "Delete" link next to your translation which
  is styled correctly.
- Confirm that the behavior of the "Delete" link is correct both when
  confirming and when canceling.

Revision adds the "actions" class to the table cell with the delete link
to prevent a line break between the icon and the text.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Brendan Gallagher 2016-03-23 00:00:17 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 7 Julian Maurice 2016-04-08 07:21:22 UTC
Patch pushed to 3.22.x, will be in 3.22.6