In my follow-up patch to Bug 10558 I made some changes to the way DataTables displayed which broke the preview of quotes uploaded to the Quote of the Day manager. 2 years, 7 months, and 28 days later I have returned to fix it.
Created attachment 48896 [details] [review] Bug 16033 - Quotes upload preview broken for 973 days A missing snippet of DataTable configuration means that when you upload a CSV of quotes to the Quotes of the Day feature the table previewing your import is not visible. This patch corrects it. To test, apply the patch and go to Tools -> Quote editor -> Import quotes. - Upload a CSV file containing data in two columns, "source","text" - When your upload completes you should see a DataTable previewing the data from your CSV. - Check that deletion of individual quotes works from the preview. - Check that quotes are correctly imported. - Ponder the long 2.66 years during which this page was broken.
Created attachment 48927 [details] [review] Bug 16033 - Quotes upload preview broken for 973 days A missing snippet of DataTable configuration means that when you upload a CSV of quotes to the Quotes of the Day feature the table previewing your import is not visible. This patch corrects it. To test, apply the patch and go to Tools -> Quote editor -> Import quotes. - Upload a CSV file containing data in two columns, "source","text" - When your upload completes you should see a DataTable previewing the data from your CSV. - Check that deletion of individual quotes works from the preview. - Check that quotes are correctly imported. - Ponder the long 2.66 years during which this page was broken. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Quote of the day: Serenity of mind comes with patience.
Created attachment 48950 [details] [review] Bug 16033 - Quotes upload preview broken for 973 days A missing snippet of DataTable configuration means that when you upload a CSV of quotes to the Quotes of the Day feature the table previewing your import is not visible. This patch corrects it. To test, apply the patch and go to Tools -> Quote editor -> Import quotes. - Upload a CSV file containing data in two columns, "source","text" - When your upload completes you should see a DataTable previewing the data from your CSV. - Check that deletion of individual quotes works from the preview. - Check that quotes are correctly imported. - Ponder the long 2.66 years during which this page was broken. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Quote of the day: Serenity of mind comes with patience. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.5
This patch has been pushed to 3.20.x, will be in 3.20.10.