Bug 16052 - Styling buttons after MARC records have been staged
Summary: Styling buttons after MARC records have been staged
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic record staging/import (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-11 00:44 UTC by Aleisha Amohia
Modified: 2016-12-05 21:27 UTC (History)
1 user (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16052: Styling buttons (1.93 KB, patch)
2016-03-11 00:46 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16052: Putting buttons from after MARC records have been staged into a toolbar (1.89 KB, patch)
2016-03-13 22:00 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16052: Putting buttons from after MARC records have been staged into a toolbar (2.71 KB, patch)
2016-03-13 22:14 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16052: Putting buttons from after MARC records have been staged into a toolbar (1.76 KB, patch)
2016-03-15 00:32 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16052: Putting buttons from after MARC records have been staged into a toolbar (2.15 KB, patch)
2016-03-15 00:35 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16052: Putting buttons from after MARC records have been staged into a toolbar (2.30 KB, patch)
2016-03-15 12:50 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16052: Putting buttons from after MARC records have been staged into a toolbar (2.32 KB, patch)
2016-03-16 08:52 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-03-11 00:44:18 UTC
At the moment, links 'Manage staged records' and 'Back' are list items once MARC records have been uploaded and staged for import. These would look better as buttons
Comment 1 Aleisha Amohia 2016-03-11 00:46:19 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2016-03-11 13:20:32 UTC
I think these buttons look good. However, my desire for logical consistency makes me wonder whether they are the correct thing to use here. Usually we use buttons to signify an action which is performed "with" something: Submitting a form, usually. These buttons are navigational.

If a plain link doesn't feel right, do we need to think about introducing a new style that is neither a plain link nor a button? And how would that fit in with other areas that have something similar?

I also think we need to think about the use of "back" links, not just where but anywhere they are used. In this case "back" might more accurately be labeled "Stage more MARC records?"
Comment 3 Aleisha Amohia 2016-03-13 21:41:13 UTC
(In reply to Owen Leonard from comment #2)
> I think these buttons look good. However, my desire for logical consistency
> makes me wonder whether they are the correct thing to use here. Usually we
> use buttons to signify an action which is performed "with" something:
> Submitting a form, usually. These buttons are navigational.
> 
> If a plain link doesn't feel right, do we need to think about introducing a
> new style that is neither a plain link nor a button? And how would that fit
> in with other areas that have something similar?
> 
> I also think we need to think about the use of "back" links, not just where
> but anywhere they are used. In this case "back" might more accurately be
> labeled "Stage more MARC records?"

Perhaps I could make a toolbar to go at the top that has the 'Manage staged records' and 'Stage more MARC records' links. I think that makes sense and would follow the rest of the site for kind of navigational buttons that take you to other pages etc
Comment 4 Aleisha Amohia 2016-03-13 22:00:38 UTC Comment hidden (obsolete)
Comment 5 Aleisha Amohia 2016-03-13 22:14:30 UTC Comment hidden (obsolete)
Comment 6 Owen Leonard 2016-03-14 23:30:39 UTC
I think this is a great solution! I have a couple of suggestions, though.

1. I don't think this needs a separate include file because it only appears in one place.

2. I think the "Stage" button should go on the left to reflect left-to-right, first step, second step.

3. I think the "Stage" button should say "Stage MARC records." I realize it only appears after you've completed a staging process, but it feels wrong to have the "more" in there.
Comment 7 Aleisha Amohia 2016-03-15 00:32:50 UTC Comment hidden (obsolete)
Comment 8 Aleisha Amohia 2016-03-15 00:35:02 UTC Comment hidden (obsolete)
Comment 9 Owen Leonard 2016-03-15 12:50:52 UTC Comment hidden (obsolete)
Comment 10 Jonathan Druart 2016-03-16 08:52:54 UTC
Created attachment 49201 [details] [review]
Bug 16052: Putting buttons from after MARC records have been staged into a toolbar

EDIT: Incorporating Owen Leonard's changes from Comment 6

To test:
1) Go to Tools -> Stage MARC records for import
2) Upload any file and click Stage for import once it has uploaded
3) Confirm both links are now buttons in a toolbar and work as expected
4) Notice that 'Stage MARC records' (what was once the 'Back' button)
   now takes you back to stage-marc-records.pl instead of tools-home.pl
5) Also confirm that the space between results and colon (MARC staging
   results :) is gone

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Thank you, this is a great improvement.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Brendan Gallagher 2016-03-23 20:52:39 UTC
Pushed to Master - should be in the May 2016 release.  Thanks!