At the moment, links 'Manage staged records' and 'Back' are list items once MARC records have been uploaded and staged for import. These would look better as buttons
Created attachment 48985 [details] [review] Bug 16052: Styling buttons To test: 1) Go to Tools -> Stage MARC records for import 2) Upload any file and click Stage for import once it has uploaded 3) Confirm both links are now buttons and behave as expected 4) Also confirm that the space between results and colon (MARC staging results :) is gone Sponsored-by: Catalyst IT
I think these buttons look good. However, my desire for logical consistency makes me wonder whether they are the correct thing to use here. Usually we use buttons to signify an action which is performed "with" something: Submitting a form, usually. These buttons are navigational. If a plain link doesn't feel right, do we need to think about introducing a new style that is neither a plain link nor a button? And how would that fit in with other areas that have something similar? I also think we need to think about the use of "back" links, not just where but anywhere they are used. In this case "back" might more accurately be labeled "Stage more MARC records?"
(In reply to Owen Leonard from comment #2) > I think these buttons look good. However, my desire for logical consistency > makes me wonder whether they are the correct thing to use here. Usually we > use buttons to signify an action which is performed "with" something: > Submitting a form, usually. These buttons are navigational. > > If a plain link doesn't feel right, do we need to think about introducing a > new style that is neither a plain link nor a button? And how would that fit > in with other areas that have something similar? > > I also think we need to think about the use of "back" links, not just where > but anywhere they are used. In this case "back" might more accurately be > labeled "Stage more MARC records?" Perhaps I could make a toolbar to go at the top that has the 'Manage staged records' and 'Stage more MARC records' links. I think that makes sense and would follow the rest of the site for kind of navigational buttons that take you to other pages etc
Created attachment 49071 [details] [review] Bug 16052: Putting buttons from after MARC records have been staged into a toolbar To test: 1) Go to Tools -> Stage MARC records for import 2) Upload any file and click Stage for import once it has uploaded 3) Confirm both links are now buttons in a toolbar and work as expected 4) Notice that 'Stage more MARC records' (what was once the 'Back' button) now takes you back to stage-marc-records.pl instead of tools-home.pl 5) Also confirm that the space between results and colon (MARC staging results :) is gone Sponsored-by: Catalyst IT
Created attachment 49073 [details] [review] Bug 16052: Putting buttons from after MARC records have been staged into a toolbar To test: 1) Go to Tools -> Stage MARC records for import 2) Upload any file and click Stage for import once it has uploaded 3) Confirm both links are now buttons in a toolbar and work as expected 4) Notice that 'Stage more MARC records' (what was once the 'Back' button) now takes you back to stage-marc-records.pl instead of tools-home.pl 5) Also confirm that the space between results and colon (MARC staging results :) is gone Sponsored-by: Catalyst IT
I think this is a great solution! I have a couple of suggestions, though. 1. I don't think this needs a separate include file because it only appears in one place. 2. I think the "Stage" button should go on the left to reflect left-to-right, first step, second step. 3. I think the "Stage" button should say "Stage MARC records." I realize it only appears after you've completed a staging process, but it feels wrong to have the "more" in there.
Created attachment 49150 [details] [review] Bug 16052: Putting buttons from after MARC records have been staged into a toolbar EDIT: Incorporating Owen Leonard's changes from Comment 6 To test: 1) Go to Tools -> Stage MARC records for import 2) Upload any file and click Stage for import once it has uploaded 3) Confirm both links are now buttons in a toolbar and work as expected 4) Notice that 'Stage MARC records' (what was once the 'Back' button) now takes you back to stage-marc-records.pl instead of tools-home.pl 5) Also confirm that the space between results and colon (MARC staging results :) is gone Sponsored-by: Catalyst IT
Created attachment 49152 [details] [review] Bug 16052: Putting buttons from after MARC records have been staged into a toolbar EDIT: Incorporating Owen Leonard's changes from Comment 6 To test: 1) Go to Tools -> Stage MARC records for import 2) Upload any file and click Stage for import once it has uploaded 3) Confirm both links are now buttons in a toolbar and work as expected 4) Notice that 'Stage MARC records' (what was once the 'Back' button) now takes you back to stage-marc-records.pl instead of tools-home.pl 5) Also confirm that the space between results and colon (MARC staging results :) is gone Sponsored-by: Catalyst IT
Created attachment 49171 [details] [review] [SIGNED-OFF] Bug 16052: Putting buttons from after MARC records have been staged into a toolbar EDIT: Incorporating Owen Leonard's changes from Comment 6 To test: 1) Go to Tools -> Stage MARC records for import 2) Upload any file and click Stage for import once it has uploaded 3) Confirm both links are now buttons in a toolbar and work as expected 4) Notice that 'Stage MARC records' (what was once the 'Back' button) now takes you back to stage-marc-records.pl instead of tools-home.pl 5) Also confirm that the space between results and colon (MARC staging results :) is gone Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Thank you, this is a great improvement.
Created attachment 49201 [details] [review] Bug 16052: Putting buttons from after MARC records have been staged into a toolbar EDIT: Incorporating Owen Leonard's changes from Comment 6 To test: 1) Go to Tools -> Stage MARC records for import 2) Upload any file and click Stage for import once it has uploaded 3) Confirm both links are now buttons in a toolbar and work as expected 4) Notice that 'Stage MARC records' (what was once the 'Back' button) now takes you back to stage-marc-records.pl instead of tools-home.pl 5) Also confirm that the space between results and colon (MARC staging results :) is gone Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Thank you, this is a great improvement. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - should be in the May 2016 release. Thanks!