If a catalog search in the staff client returns no results a Z39.50/SRU search button is shown. This button could use a Font Awesome icon.
Created attachment 49095 [details] [review] Bug 16060 - Add Font Awesome icon to Z39.50 search button when no results are found When a staff client catalog search returns no results, a Z39.50/SRU search button is shown. This patch adds a Font Awesome icon to that button. Also changed: A stray extra double quote has been removed. The onclick attribute has been removed from the search button in favor of an event already defined. To test, apply the patch and perform a search in the staff client catalog which will return no results. - Confirm that the Z39.50/SRU button looks correct and works correctly. - Validate the HTML of the page and confirm that no unexpected errors are returned.
This is the only validation error I got. This patch didn't cause it. So I'm going to sign off. Warning: Empty heading. From line 420, column 1; to line 420, column 14 radient">↩<h1 id="logo"><a hre
Created attachment 49366 [details] [review] Bug 16060 - Add Font Awesome icon to Z39.50 search button when no results are found When a staff client catalog search returns no results, a Z39.50/SRU search button is shown. This patch adds a Font Awesome icon to that button. Also changed: A stray extra double quote has been removed. The onclick attribute has been removed from the search button in favor of an event already defined. To test, apply the patch and perform a search in the staff client catalog which will return no results. - Confirm that the Z39.50/SRU button looks correct and works correctly. - Validate the HTML of the page and confirm that no unexpected errors are returned. NOTE: Pretty! Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 49381 [details] [review] [PASSED QA] Bug 16060 - Add Font Awesome icon to Z39.50 search button when no results are found When a staff client catalog search returns no results, a Z39.50/SRU search button is shown. This patch adds a Font Awesome icon to that button. Also changed: A stray extra double quote has been removed. The onclick attribute has been removed from the search button in favor of an event already defined. To test, apply the patch and perform a search in the staff client catalog which will return no results. - Confirm that the Z39.50/SRU button looks correct and works correctly. - Validate the HTML of the page and confirm that no unexpected errors are returned. NOTE: Pretty! Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to M. Tompsett from comment #2) > This is the only validation error I got. > > Warning: Empty heading. The heading is empty if you don't have the "LibraryName" system preference populated.
Pushed to Master - Should be in the May 2016 release. Thanks!