When adding a new patron, if a duplicate patron is suspected a dialog is shown. This dialog should use Font Awesome icons.
Created attachment 49099 [details] [review] Bug 16065 - Use Font Awesome icons in dialog when duplicate patron is suspected This patch updates the new patron template to use Font Awesome icons in the dialog which is shown when a duplicate patron is suspected. The patch modifies the CSS rules for a dialog button with "white-space: pre-line" so that line breaks in button text markup are treated as line breaks on display. Allowing the text to wrap prevents the buttons from being too wide and stacking one below the other. To test, apply the patch and go to Patrons -> New patron. - Attempt to save a new patron with details matching an existing patron in order to trigger the duplicate patron warning. - Confirm that the resulting dialog is styled correctly. - Confirm the behavior of both the 'Edit existing' and 'Save as new' buttons.
Created attachment 49112 [details] [review] Bug 16065 - Use Font Awesome icons in dialog when duplicate patron is suspected This patch updates the new patron template to use Font Awesome icons in the dialog which is shown when a duplicate patron is suspected. The patch modifies the CSS rules for a dialog button with "white-space: pre-line" so that line breaks in button text markup are treated as line breaks on display. Allowing the text to wrap prevents the buttons from being too wide and stacking one below the other. To test, apply the patch and go to Patrons -> New patron. - Attempt to save a new patron with details matching an existing patron in order to trigger the duplicate patron warning. - Confirm that the resulting dialog is styled correctly. - Confirm the behavior of both the 'Edit existing' and 'Save as new' buttons. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 49174 [details] [review] Bug 16065 - Use Font Awesome icons in dialog when duplicate patron is suspected This patch updates the new patron template to use Font Awesome icons in the dialog which is shown when a duplicate patron is suspected. The patch modifies the CSS rules for a dialog button with "white-space: pre-line" so that line breaks in button text markup are treated as line breaks on display. Allowing the text to wrap prevents the buttons from being too wide and stacking one below the other. To test, apply the patch and go to Patrons -> New patron. - Attempt to save a new patron with details matching an existing patron in order to trigger the duplicate patron warning. - Confirm that the resulting dialog is styled correctly. - Confirm the behavior of both the 'Edit existing' and 'Save as new' buttons. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 release. Thanks!