Bug 16071 - Use Font Awesome icons in authority record duplicate warning dialog
Summary: Use Font Awesome icons in authority record duplicate warning dialog
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/cataloguing/authorities.pl
Keywords:
Depends on:
Blocks: 16080
  Show dependency treegraph
 
Reported: 2016-03-14 17:33 UTC by Owen Leonard
Modified: 2016-12-05 21:27 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16071 - Use Font Awesome icons in authority duplicate warning dialog (3.00 KB, patch)
2016-03-14 17:49 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 16071: Use Font Awesome icons in authority duplicate warning dialog (3.05 KB, patch)
2016-03-16 14:51 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 16071: Use Font Awesome icons in authority duplicate warning dialog (3.11 KB, patch)
2016-03-17 09:08 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-14 17:33:03 UTC
In the authority record editor, if a duplicate record is suspected a dialog is shown. This dialog should use Font Awesome icons.
Comment 1 Owen Leonard 2016-03-14 17:49:59 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-03-16 14:51:07 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-17 09:08:41 UTC
Created attachment 49246 [details] [review]
Bug 16071: Use Font Awesome icons in authority duplicate warning dialog

In the authority editor, when a duplicate record is suspected a
dialog is shown. This patch updates the template to show Font Awesome
icons in this dialog.

Also changed: Using <h3> instead of <h4> in dialog so that it is
correctly styled. Adding "popup" class to duplicate record link to
indicate that a new window will be opened.

To test, apply the patch and go to Authorities -> New record.

- Use Z39.50 to import a record which is already in your catalog.
- Save the record. Confirm that the duplicate warning dialog is styled
  correctly.
- Confirm that both the "Save as new" and "Edit existing" buttons work
  correctly.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-23 20:44:23 UTC
Pushed to Master - should be in the May 2016 release.  Thanks!