Right now we have two spinner gifs for use when a "loading" icon is needed: spinner-small.gif loading-small.gif We only need one. The latter is used more often, but the former is transparent and thus probably more versatile and should be kept.
Created attachment 49155 [details] [review] Bug 16072: Changing all instances of 'loading-small.gif' to 'spinner-small.gif' and removing loading-small.gif file. Confirm that I have not missed any places where there is 'loading-small.gif' Sponsored-by: Catalyst IT
This patch changes OPAC CSS, which is outside the scope of this bug. - I'm pretty sure the relevant OPAC CSS isn't actually used... I can't find any reference to autocomplete being used in the OPAC. - Neither loading-small.gif nor spinner-small.gif exist in the OPAC, so changing one for the other isn't making progress. - For future reference, I think the QA and RM teams like changes to opac.css to be submitted as a separate patch.
Created attachment 58102 [details] [review] Bug 16072: Changing all instances of 'loading-small.gif' to 'spinner-small.gif' and removing loading-small.gif file. Confirm that I have not missed any places where there is 'loading-small.gif' Have amended patch to not include OPAC changes from previous patch. Sponsored-by: Catalyst IT
Created attachment 58187 [details] [review] [SIGNED-OFF] Bug 16072: Changing all instances of 'loading-small.gif' to 'spinner-small.gif' and removing loading-small.gif file. Confirm that I have not missed any places where there is 'loading-small.gif' Have amended patch to not include OPAC changes from previous patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 58448 [details] [review] Bug 16072: Changing all instances of 'loading-small.gif' to 'spinner-small.gif' and removing loading-small.gif file. Confirm that I have not missed any places where there is 'loading-small.gif' Have amended patch to not include OPAC changes from previous patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master for 17.05, thanks Aleisha!
This won't get ported back to 16.11.x as it is an enhancement.