The YUI CSS file "skin.css" is no longer in use anywhere in the staff client and can be removed. Any references to YUI classes /other than grids/ can be removed as well.
Created attachment 49173 [details] [review] Bug 16078 - Remove unused YUI CSS The YUI CSS file "skin.css" is no longer relevant to the staff client templates and can be removed. Other references to YUI-related classes, with the exception of grids, can also be removed. This patch removes references in CSS to: .yuimenuitemlabel .yui-button .yui-menu-button ...and removes the "yui-skin-sam" class from two templates' body tag. To test, apply the patch and clear your cache if necessary. Look around and confirm that the style of the staff client is unchanged. Search for references to the listed classes and confirm that none are found.
Hi Owen, I found some references after applying the patch: git grep 'yuimenuitemlabel' 1 line in: installer/data/mysql/updatedatabase.pl git grep 'yui-button' 3 lines in: koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/card-print.tt .yui-menu-button OK
Ah, found, Bug 16077 removes card-print.tt 'yuimenuitemlabel' in installer/data/mysql/updatedatabase.pl is on line 2601 ($DBversion 3.01.00.050), I assume it does not harm.
Created attachment 49177 [details] [review] Bug 16078 - Remove unused YUI CSS The YUI CSS file "skin.css" is no longer relevant to the staff client templates and can be removed. Other references to YUI-related classes, with the exception of grids, can also be removed. This patch removes references in CSS to: .yuimenuitemlabel .yui-button .yui-menu-button ...and removes the "yui-skin-sam" class from two templates' body tag. To test, apply the patch and clear your cache if necessary. Look around and confirm that the style of the staff client is unchanged. Search for references to the listed classes and confirm that none are found. Signed-off-by: Marc Véron <veron@veron.ch>
I see one more place where "skin.css" is referenced, so I'll submit a follow-up.
Created attachment 49182 [details] [review] Bug 16078 [Follow-up] Remove unused YUI CSS skin.css is also included in a list of assets cached by the offline circulation page. It can be safely removed.
Created attachment 49189 [details] [review] Bug 16078 [Follow-up] Remove unused YUI CSS skin.css is also included in a list of assets cached by the offline circulation page. It can be safely removed. Signed-off-by: Marc Véron <veron@veron.ch>
Owen, There are 2 occurrences of skin.css left in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css koha-tmpl/intranet-tmpl/prog/en/lib/yui/utilities/utilities.js
(In reply to Jonathan Druart from comment #8) > Owen, > There are 2 occurrences of skin.css left in > koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Whoops. I made a mistake when squashing some commits! > koha-tmpl/intranet-tmpl/prog/en/lib/yui/utilities/utilities.js This file is only used by basketgroups.pl and as far as I can tell removing the CSS file has no affect on the functionality or style of that page.
Created attachment 49220 [details] [review] Bug 16078 [Revised] Remove unused YUI CSS The YUI CSS file "skin.css" is no longer relevant to the staff client templates and can be removed. Other references to YUI-related classes, with the exception of grids, can also be removed. This patch removes references in CSS to: .yuimenuitemlabel .yui-button .yui-menu-button ...and removes the "yui-skin-sam" class from two templates' body tag. skin.css is also included in a list of assets cached by the offline circulation page. It can be safely removed. To test, apply the patch and clear your cache if necessary. Look around and confirm that the style of the staff client is unchanged. Search for references to the listed classes and confirm that none are found. Revised patch squashes in the follow-up as well as a missing commit removing skin.css from staff-global.css.
Created attachment 49222 [details] [review] Bug 16078 [Revised] Remove unused YUI CSS The YUI CSS file "skin.css" is no longer relevant to the staff client templates and can be removed. Other references to YUI-related classes, with the exception of grids, can also be removed. This patch removes references in CSS to: .yuimenuitemlabel .yui-button .yui-menu-button ...and removes the "yui-skin-sam" class from two templates' body tag. skin.css is also included in a list of assets cached by the offline circulation page. It can be safely removed. To test, apply the patch and clear your cache if necessary. Look around and confirm that the style of the staff client is unchanged. Search for references to the listed classes and confirm that none are found. Revised patch squashes in the follow-up as well as a missing commit removing skin.css from staff-global.css. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 49250 [details] [review] Bug 16078 [Revised] Remove unused YUI CSS The YUI CSS file "skin.css" is no longer relevant to the staff client templates and can be removed. Other references to YUI-related classes, with the exception of grids, can also be removed. This patch removes references in CSS to: .yuimenuitemlabel .yui-button .yui-menu-button ...and removes the "yui-skin-sam" class from two templates' body tag. skin.css is also included in a list of assets cached by the offline circulation page. It can be safely removed. To test, apply the patch and clear your cache if necessary. Look around and confirm that the style of the staff client is unchanged. Search for references to the listed classes and confirm that none are found. Revised patch squashes in the follow-up as well as a missing commit removing skin.css from staff-global.css. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 release. Thanks!