Bug 16078 - Remove unused YUI CSS
Summary: Remove unused YUI CSS
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 16077
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-15 14:28 UTC by Owen Leonard
Modified: 2016-12-05 21:27 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16078 - Remove unused YUI CSS (88.80 KB, patch)
2016-03-15 14:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16078 - Remove unused YUI CSS (88.90 KB, patch)
2016-03-15 15:29 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16078 [Follow-up] Remove unused YUI CSS (1.10 KB, patch)
2016-03-15 16:18 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16078 [Follow-up] Remove unused YUI CSS (1.20 KB, patch)
2016-03-15 16:47 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16078 [Revised] Remove unused YUI CSS (89.89 KB, patch)
2016-03-16 12:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16078 [Revised] Remove unused YUI CSS (89.99 KB, patch)
2016-03-16 13:21 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16078 [Revised] Remove unused YUI CSS (90.05 KB, patch)
2016-03-17 09:41 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-15 14:28:52 UTC
The YUI CSS file "skin.css" is no longer in use anywhere in the staff client and can be removed.

Any references to YUI classes /other than grids/ can be removed as well.
Comment 1 Owen Leonard 2016-03-15 14:36:38 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-03-15 15:16:30 UTC
Hi Owen, I found some references after applying the patch:


git grep 'yuimenuitemlabel'
1 line in:
installer/data/mysql/updatedatabase.pl

git grep 'yui-button'
3 lines in:
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/card-print.tt

.yui-menu-button
OK
Comment 3 Marc Véron 2016-03-15 15:23:09 UTC
Ah, found, Bug 16077 removes card-print.tt


'yuimenuitemlabel' in installer/data/mysql/updatedatabase.pl is on line 2601 ($DBversion 3.01.00.050), I assume it does not harm.
Comment 4 Marc Véron 2016-03-15 15:29:02 UTC Comment hidden (obsolete)
Comment 5 Owen Leonard 2016-03-15 16:15:56 UTC
I see one more place where "skin.css" is referenced, so I'll submit a follow-up.
Comment 6 Owen Leonard 2016-03-15 16:18:13 UTC Comment hidden (obsolete)
Comment 7 Marc Véron 2016-03-15 16:47:27 UTC Comment hidden (obsolete)
Comment 8 Jonathan Druart 2016-03-16 10:35:09 UTC
Owen,
There are 2 occurrences of skin.css left in
koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
koha-tmpl/intranet-tmpl/prog/en/lib/yui/utilities/utilities.js
Comment 9 Owen Leonard 2016-03-16 12:09:34 UTC
(In reply to Jonathan Druart from comment #8)
> Owen,
> There are 2 occurrences of skin.css left in
> koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css

Whoops. I made a mistake when squashing some commits!

> koha-tmpl/intranet-tmpl/prog/en/lib/yui/utilities/utilities.js

This file is only used by basketgroups.pl and as far as I can tell removing the CSS file has no affect on the functionality or style of that page.
Comment 10 Owen Leonard 2016-03-16 12:19:06 UTC Comment hidden (obsolete)
Comment 11 Marc Véron 2016-03-16 13:21:56 UTC Comment hidden (obsolete)
Comment 12 Jonathan Druart 2016-03-17 09:41:45 UTC
Created attachment 49250 [details] [review]
Bug 16078 [Revised] Remove unused YUI CSS

The YUI CSS file "skin.css" is no longer relevant to the staff client
templates and can be removed. Other references to YUI-related classes,
with the exception of grids, can also be removed.

This patch removes references in CSS to:

.yuimenuitemlabel
.yui-button
.yui-menu-button

...and removes the "yui-skin-sam" class from two templates' body tag.

skin.css is also included in a list of assets cached by the offline
circulation page. It can be safely removed.

To test, apply the patch and clear your cache if necessary. Look around
and confirm that the style of the staff client is unchanged.

Search for references to the listed classes and confirm that none are
found.

Revised patch squashes in the follow-up as well as a missing commit
removing skin.css from staff-global.css.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 13 Brendan Gallagher 2016-03-23 01:04:18 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!