Bug 16120 - Making action on patron search a button
Summary: Making action on patron search a button
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-22 03:19 UTC by Aleisha Amohia
Modified: 2016-12-05 21:27 UTC (History)
6 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16120: Making 'Edit' on patron search a button (1.55 KB, patch)
2016-03-22 03:20 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16120: Making 'Edit' on patron search a button (1.81 KB, patch)
2016-03-23 03:23 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16120: Making 'Edit' on patron search a button (1.94 KB, patch)
2016-03-23 08:34 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 16120: Making 'Edit' on patron search a button (2.01 KB, patch)
2016-03-23 21:41 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 16120: Making 'Edit' on patron search a button (2.07 KB, patch)
2016-03-23 22:05 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16120: Add the actions class to all actions td (4.26 KB, patch)
2016-03-23 22:06 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 16120: Making 'Edit' on patron search a button (2.13 KB, patch)
2016-03-23 22:17 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 16120: Add the actions class to all actions td (4.33 KB, patch)
2016-03-23 22:17 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-03-22 03:19:29 UTC

    
Comment 1 Aleisha Amohia 2016-03-22 03:20:51 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2016-03-22 12:44:38 UTC
The table cell containing the button needs an "action" class.
Comment 3 Aleisha Amohia 2016-03-23 03:23:48 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2016-03-23 08:34:28 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2016-03-23 21:41:49 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2016-03-23 22:00:01 UTC
Working on a counter patch.
Comment 7 Jonathan Druart 2016-03-23 22:05:41 UTC Comment hidden (obsolete)
Comment 8 Jonathan Druart 2016-03-23 22:06:09 UTC Comment hidden (obsolete)
Comment 9 Jonathan Druart 2016-03-23 22:06:38 UTC
(In reply to Jonathan Druart from comment #6)
> Working on a counter patch.

Just a follow-up finally.
Comment 10 Katrin Fischer 2016-03-23 22:17:52 UTC
Created attachment 49478 [details] [review]
[PASSED QA] Bug 16120: Making 'Edit' on patron search a button

EDIT: Adding nowrap styles to the Action column. I chose to do it with a span because that's the way it's already done in this file for another column.

To test:
1) Go to Patrons and do a search that will bring up more than one result
2) Confirm 'Edit' now shows as a font awesome button and works as expected
3) Confirm the button does not wrap when you make your browser narrower

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Katrin Fischer 2016-03-23 22:17:55 UTC
Created attachment 49479 [details] [review]
[PASSED QA] Bug 16120: Add the actions class to all actions td

We have several others places where a td contains buttons. This patch
fixes the ones in table generated server-side.

Test plan:
Search for patrons and shelves: the buttons should not wrap

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Brendan Gallagher 2016-03-24 17:07:46 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!