When placing a new order, the budget dropdown will display the budget hierarchy. TEST PLAN : 1. Go to the Administration module 2. Add a new budget (ie : Budget 2016) 3. Add a fund to this budget (ie : Book) 4. Add a child fund (ie : Adult fiction) You will have this hierarchy : Budget 2016 |____ Book |_____ Adult fiction 5. Go to the Acquisition module 6. Select a vendor and create a new basket 7. Place an order 8. Check the budget dropdown menu BEFORE PATCH Book Adult fiction AFTER PATCH Book Adult fiction
Created attachment 50436 [details] [review] Bug 16123 - Display budget hierarchy in the budget dropdown menu used when placing a new order When placing a new order, the budget dropdown will display the budget hierarchy. TEST PLAN : 1. Go to the Administration module 2. Add a new budget (ie : Budget 2016) 3. Add a fund to this budget (ie : Book) 4. Add a child fund (ie : Adult fiction) You will have this hierarchy : Budget 2016 |____ Book |_____ Adult fiction 5. Go to the Acquisition module 6. Select a vendor and create a new basket 7. Place an order 8. Check the budget dropdown menu BEFORE PATCH Book Adult fiction AFTER PATCH Book Adult fiction
Created attachment 51933 [details] [review] Bug 16123 - Display budget hierarchy in the budget dropdown menu used when placing a new order When placing a new order, the budget dropdown will display the budget hierarchy. TEST PLAN : 1. Go to the Administration module 2. Add a new budget (ie : Budget 2016) 3. Add a fund to this budget (ie : Book) 4. Add a child fund (ie : Adult fiction) You will have this hierarchy : Budget 2016 |____ Book |_____ Adult fiction 5. Go to the Acquisition module 6. Select a vendor and create a new basket 7. Place an order 8. Check the budget dropdown menu BEFORE PATCH Book Adult fiction AFTER PATCH Book Adult fiction Dropbown menu is hierarchical as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Philippe, Please provide tests.
Created attachment 56303 [details] [review] Bug 16123 - Add unit tests
Created attachment 56406 [details] [review] Bug 16123 - Display budget hierarchy in the budget dropdown menu used when placing a new order When placing a new order, the budget dropdown will display the budget hierarchy. TEST PLAN : 1. Go to the Administration module 2. Add a new budget (ie : Budget 2016) 3. Add a fund to this budget (ie : Book) 4. Add a child fund (ie : Adult fiction) You will have this hierarchy : Budget 2016 |____ Book |_____ Adult fiction 5. Go to the Acquisition module 6. Select a vendor and create a new basket 7. Place an order 8. Check the budget dropdown menu BEFORE PATCH Book Adult fiction AFTER PATCH Book Adult fiction Dropbown menu is hierarchical as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Created attachment 56407 [details] [review] Bug 16123 - Add unit tests Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Making the 1st level bold for me doesn't look quite right. I think it gives you the idea that you can't order from that level, as it looks like an option group. For libraries that don't use child funds, it will just all be bold (most if not all of ours). I've looked at the receive screen too and bold is used there for the budget level - maybe something that could be added later on. I am proposing a follow-up removing the bold formatting.
Created attachment 56890 [details] [review] [PASSED QA] Bug 16123 - Display budget hierarchy in the budget dropdown menu used when placing a new order When placing a new order, the budget dropdown will display the budget hierarchy. TEST PLAN : 1. Go to the Administration module 2. Add a new budget (ie : Budget 2016) 3. Add a fund to this budget (ie : Book) 4. Add a child fund (ie : Adult fiction) You will have this hierarchy : Budget 2016 |____ Book |_____ Adult fiction 5. Go to the Acquisition module 6. Select a vendor and create a new basket 7. Place an order 8. Check the budget dropdown menu BEFORE PATCH Book Adult fiction AFTER PATCH Book Adult fiction Dropbown menu is hierarchical as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 56891 [details] [review] [PASSED QA] Bug 16123 - Add unit tests Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 56892 [details] [review] Bug 16123: Remove bold formatting from first level fund
Please check if you agree with the last patch before pushing.
Pushed to master for 16.11, thanks Philippe, Bouzid, Katrin!