The "Add a new message" link is no longer visible on the checkout screen if no other messages are present. A sidebar on the right shows patron messages, if any, including hold waiting notices, outstanding fines, messages on their account, etc. Before Bug 15632 that sidebar displayed all the time, even if no messages were present. This wasn't ideal, but at least it created a space for the "Add new message" link to appear. Now that the sidebar is gone if there are no messages we need a place for the "Add new message" link. I think coming up with a new place for it is better than making it work like it did before.
Created attachment 49450 [details] [review] Bug 16125: Remove the flagged boolean in circ/circulation.tt Before 15632, flagged was passed in any cases: GetMessages returned an arrayref, so: my $bor_messages_loop = GetMessages( $borrowernumber, 'B', $branch ); if($bor_messages_loop){ $template->param(flagged => 1 ); } set 'flagged'. It seems that this variable is not needed as it's always set. Test plan: Confirm that the "Add a new message" link is always displayed (even if no message exist). Note that a "Attention" is displayed but should not, that already existed before bug 15632.
Created attachment 49454 [details] [review] Bug 16125: Remove the flagged boolean in circ/circulation.tt Before 15632, flagged was passed in any cases: GetMessages returned an arrayref, so: my $bor_messages_loop = GetMessages( $borrowernumber, 'B', $branch ); if($bor_messages_loop){ $template->param(flagged => 1 ); } set 'flagged'. It seems that this variable is not needed as it's always set. Test plan: Confirm that the "Add a new message" link is always displayed (even if no message exist). Note that a "Attention" is displayed but should not, that already existed before bug 15632. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 49463 [details] [review] [PASSED QA] Bug 16125: Remove the flagged boolean in circ/circulation.tt Before 15632, flagged was passed in any cases: GetMessages returned an arrayref, so: my $bor_messages_loop = GetMessages( $borrowernumber, 'B', $branch ); if($bor_messages_loop){ $template->param(flagged => 1 ); } set 'flagged'. It seems that this variable is not needed as it's always set. Test plan: Confirm that the "Add a new message" link is always displayed (even if no message exist). Note that a "Attention" is displayed but should not, that already existed before bug 15632. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to Master - Should be in the May 2016 release. Thanks!
Not needed in 3.22.x, status changed to RESOLVED