The patron discharge feature added a "Discharge" tab in the left-hand sidebar menu. I think if we follow views vs. actions guideline (https://wiki.koha-community.org/wiki/Interface_patterns#Views_and_Actions), the link in the sidebar should say "Discharges" (as in view the patron's list of discharges) and there should be menu item in the toolbar (members-toolbar.inc) for the action of discharging the patron. I think this should be added to the "More" drop-down menu.
Created attachment 51927 [details] [review] Bug 16127 - Add discharge menu item to patron toolbar This patch changes the "Discharge" menu in the patron sidebar to read "Discharges," and adds a "Discharge" menu item to the patron toolbar. This adds some redunancy, but fits with the pattern of including "views" in the sidebar and "actions" in the menu. The discharge feature can be thought of either way. To test you must have the 'useDischarge' system preference enabled. - View the detail page for any patron. - Confirm that the sidebar menu reads "Discharges." - Confirm that the "More" menu contains a "Discharge" link which works correctly.
Created attachment 51932 [details] [review] Bug 16127 - Add discharge menu item to patron toolbar This patch changes the "Discharge" menu in the patron sidebar to read "Discharges," and adds a "Discharge" menu item to the patron toolbar. This adds some redunancy, but fits with the pattern of including "views" in the sidebar and "actions" in the menu. The discharge feature can be thought of either way. To test you must have the 'useDischarge' system preference enabled. - View the detail page for any patron. - Confirm that the sidebar menu reads "Discharges." - Confirm that the "More" menu contains a "Discharge" link which works correctly. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 52285 [details] [review] Bug 16127 - Add discharge menu item to patron toolbar This patch changes the "Discharge" menu in the patron sidebar to read "Discharges," and adds a "Discharge" menu item to the patron toolbar. This adds some redunancy, but fits with the pattern of including "views" in the sidebar and "actions" in the menu. The discharge feature can be thought of either way. To test you must have the 'useDischarge' system preference enabled. - View the detail page for any patron. - Confirm that the sidebar menu reads "Discharges." - Confirm that the "More" menu contains a "Discharge" link which works correctly. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for Koha 16.11, thanks Owen!
Pushed in 16.05. Will be in 16.05.01.
Patch pushed to 3.22.x, will be in 3.22.9