Bug 16129 - Remove URL::Encode dependency
Summary: Remove URL::Encode dependency
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Keywords:
Depends on: 11622
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-22 23:04 UTC by Tomás Cohen Arazi
Modified: 2016-12-05 21:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16129: Remove URL::Encode dependency (4.17 KB, patch)
2016-03-22 23:54 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 16129: Remove URL::Encode dependency (4.22 KB, patch)
2016-03-31 19:06 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 16129: Remove URL::Encode dependency (4.28 KB, patch)
2016-04-01 14:26 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2016-03-22 23:04:02 UTC
Bug 11622 introduced a dependency which can be avoided. This is important to avoid packaging it.
Comment 1 Tomás Cohen Arazi 2016-03-22 23:54:26 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens 2016-03-31 19:06:07 UTC Comment hidden (obsolete)
Comment 3 Nick Clemens 2016-03-31 19:07:40 UTC
Worked as advertised
Comment 4 Martin Renvoize 2016-04-01 14:26:42 UTC
Created attachment 49791 [details] [review]
Bug 16129: Remove URL::Encode dependency

This patch makes the PayPal integration feature independent from the
URL::Encode library, which is absent in some supported distributions.

It uses the URI package which is already a Koha dependency.

To test:
- Apply the patch
- Notice there are no deps for URL::Encode
- Follow the steps from the original patch
=> SUCCESS: It works as expected
- Sign-off :-D

Note: I deleted the line in which $amount_to_pay was url-encoded, because that's
one of the things query_form does (and the variable is only used as a parameter to it).

Sponsored-by: ByWater Solutions

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2016-04-01 14:27:18 UTC
Good move Tomas, works as advertised, removes the dependency without causing any issues.
Comment 6 Brendan Gallagher 2016-04-01 18:48:45 UTC
Pushed to Master - Should be in the 2016 release.  Thanks!
Comment 7 Julian Maurice 2016-04-07 07:43:32 UTC
Not needed in stable versions, status changed to RESOLVED