Bug 16133 - Translatability of database administrator account warning
Summary: Translatability of database administrator account warning
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-23 06:37 UTC by Marc Véron
Modified: 2016-12-05 21:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 16133: Translatability of database administrator account warning (2.19 KB, patch)
2016-03-23 07:21 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16133: Translatability of database administrator account warning (2.37 KB, patch)
2016-03-23 21:00 UTC, Mark Tompsett
Details | Diff | Splinter Review
[PASSED QA] Bug 16133: Translatability of database administrator account warning (2.44 KB, patch)
2016-03-23 21:19 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2016-03-23 06:37:53 UTC
If you log in to the staff client as database administrator, you get a warning with the following sentence, splitted by <a> tags:

You should 
create a patron 
to use when administering Koha and give it superlibrarian permissions.

Without context, it is difficult to translate correctly.

Weird result in German:

Sie müssen Benutzer anlegen zur Administration von Koha verwenden und die Berechtigung superlibrarian vergeben.
Comment 1 Marc Véron 2016-03-23 07:21:09 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2016-03-23 21:00:16 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-03-23 21:19:02 UTC
Created attachment 49461 [details] [review]
[PASSED QA] Bug 16133: Translatability of database administrator account warning

This patch removes sentence splitting of the database administrator warning with
a button styled link.

Additionally, it uses the same wording as in the warning on the 'About' page.

To test:

- Apply patch
- Log in to Staff client as database administration user
- Verify that the wording of the warning is the same as on the About page (Tab
  'System information')
- Verify that the link to the patron administration page is styled as a button
  and behaves correctly

NOTE: Actually, the category is irrelevant. But I like the improved message.
      Categories may or may not be set up at the initial log in.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Brendan Gallagher 2016-03-24 17:00:25 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-04-08 07:24:27 UTC
Patch pushed to 3.22.x, will be in 3.22.6