Bug 16138 - Restart plack when rotating logfiles
Summary: Restart plack when rotating logfiles
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: 3.22
Hardware: All All
: P5 - low major (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-23 19:00 UTC by Tomás Cohen Arazi
Modified: 2019-06-27 09:24 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16138: Restart plack when rotating logfiles (2.26 KB, patch)
2016-03-28 19:04 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 16138: Restart plack when rotating logfiles (2.31 KB, patch)
2016-03-31 14:06 UTC, Mirko Tietgen
Details | Diff | Splinter Review
Bug 16138: Restart plack when rotating logfiles (2.38 KB, patch)
2016-04-01 14:31 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2016-03-23 19:00:03 UTC
On rotating logs, Plack should be restart to avoid permission problems.
Comment 1 Tomás Cohen Arazi 2016-03-28 19:04:32 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2016-03-31 14:06:45 UTC Comment hidden (obsolete)
Comment 3 Mirko Tietgen 2016-03-31 14:08:21 UTC
I could not reproduce the issue, only tested for regression. With patch applied, Koha with Plack still works after forcing logrotate.
Comment 4 Martin Renvoize 2016-04-01 14:31:46 UTC
Created attachment 49792 [details] [review]
Bug 16138: Restart plack when rotating logfiles

On log rotation Starman/Plack keeps failing (Auth.pm related problems) due to
permission issues:

Could not compile /usr/share/koha/opac/cgi-bin/opac/opac-search.pl: Can't locate Authen/CAS/Client/Response/Failure.pm
:   ./Authen/CAS/Client/Response/Failure.pm: Permission denied at /usr/share/perl/5.20/base.pm line 97.
        ...propagated at /usr/share/perl/5.20/base.pm line 106.
BEGIN failed--compilation aborted at /usr/share/perl5/Authen/CAS/Client/Response.pm line 68.
Compilation failed in require at /usr/share/perl5/Authen/CAS/Client.pm line 8.
BEGIN failed--compilation aborted at /usr/share/perl5/Authen/CAS/Client.pm line 8.
Compilation failed in require at /usr/share/koha/lib/C4/Auth_with_cas.pm line 25.
BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth_with_cas.pm line 25.
Compilation failed in require at /usr/share/koha/lib/C4/Auth.pm line 63.
BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth.pm line 90.
Compilation failed in require at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34.
BEGIN failed--compilation aborted at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34.

As we do with zebra daemons, starman should be restarted as it doesn't handle log file rotation
gracefully[1].

I'm not sure how to reproduce it on a dev environment.

[1] https://github.com/miyagawa/Starman/issues/55

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2016-04-01 14:32:24 UTC
Simple, but effective. I managed to replicated the issues, and his patch fixed them.

Cheers Tomas
Comment 6 Brendan Gallagher 2016-04-01 18:47:29 UTC
Pushed to Master - Should be in the 2016 release.  Thanks!
Comment 7 Julian Maurice 2016-04-06 13:21:16 UTC
Patch pushed to 3.22.x, will be in 3.22.6