Looks like https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 might have broken the ability to place holds from lists. * selected the public list * placed a check next to the first and fourth items on the list at the top of the list, I selected 'Place Hold' * Got the following error message: Can't call method "field" on an undefined value at /home/load17/kohaclone/C4/Items.pm line 1491.
Created attachment 49620 [details] [review] Bug 16151: Restore the ability to place holds from lists at the OPAC This patch fixes a bug introduced by bug 14544. Holds can not be placed from lists at the OPAC, the action results in a crash: Can't call method "field" on an undefined value at /home/koha/src/C4/Items.pm line 1504. at /home/koha/src/opac/opac-reserve.pl line 601 Before 14544, the checkboxes were named 'ACT-$BIBNUM', something like REM-4242. Now we can retrieve the biblionumber from the value. Test plan: Select a public list check some titles and click on the 'Place hold' link you should able to process the reservation
We want to see this fixes pushed to the next 3.22 release.
Created attachment 49623 [details] [review] Bug 16151: Restore the ability to place holds from lists at the OPAC This patch fixes a bug introduced by bug 14544. Holds can not be placed from lists at the OPAC, the action results in a crash: Can't call method "field" on an undefined value at /home/koha/src/C4/Items.pm line 1504. at /home/koha/src/opac/opac-reserve.pl line 601 Before 14544, the checkboxes were named 'ACT-$BIBNUM', something like REM-4242. Now we can retrieve the biblionumber from the value. Test plan: Select a public list check some titles and click on the 'Place hold' link you should able to process the reservation Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 49646 [details] [review] Bug 16151: Restore the ability to place holds from lists at the OPAC This patch fixes a bug introduced by bug 14544. Holds can not be placed from lists at the OPAC, the action results in a crash: Can't call method "field" on an undefined value at /home/koha/src/C4/Items.pm line 1504. at /home/koha/src/opac/opac-reserve.pl line 601 Before 14544, the checkboxes were named 'ACT-$BIBNUM', something like REM-4242. Now we can retrieve the biblionumber from the value. Test plan: Select a public list check some titles and click on the 'Place hold' link you should able to process the reservation Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Pushed to Master - Should be in the May 2016 Release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.6